[Openvpn-devel] [XS] Change in openvpn[master]: options: Do not hide variables from parent scope

2023-08-10 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/320?usp=email ) Change subject: options: Do not hide variables from parent scope .. Patc

[Openvpn-devel] [S] Change in openvpn[master]: Add warning if a p2p NCP client connects to a p2mp server

2023-08-10 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/323?usp=email to review the following change. Change subject: Add warning if a p2p NCP client connects to a p2mp server

[Openvpn-devel] [PATCH v2] Fix unaligned access in macOS/Solaris hwaddr

2023-08-10 Thread Arne Schwabe
The undefined behaviour USAN clang checker found this. This fix is a bit messy but so are the original structures. Patch v2: handle the fact we need to beyond the struct ifr correctly when mapping the result to struct sockaddr_dl Change-Id: Ia797c8801fa9a9bc10b6674efde5fdbd7132e4a8 Sig

[Openvpn-devel] [S] Change in openvpn[master]: Add warning if a p2p NCP client connects to a p2mp server

2023-08-10 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/323?usp=email ) Change subject: Add warning if a p2p NCP client connects to a p2mp server