[Openvpn-devel] [PATCH applied] Re: get_user_pass_cr: get password from stdin if missing inline

2022-10-09 Thread Gert Doering
Acked-by: Gert Doering Amazingly trivial, as soon as one understands the intricacies of get_user_pass_cr() ;-) - of course I have tested this. Without the patch, with no password will send an empty password, with the patch, it will query on stdin and things will succeed (hard to test in an auto

Re: [Openvpn-devel] [PATCHv2] Allow inlining of --auth-user-pass

2022-10-09 Thread Gert Doering
Hi, On Sat, Oct 12, 2013 at 06:30:36PM +0200, Davide Brini wrote: > This patch allows inlining of the --auth-user-pass directive, so it is now > possible to do > > > myusername > mypassword > So, after close to 9 years, we finally managed to get that functionality in, hooray :-) commit 7d48d3

Re: [Openvpn-devel] [PATCH] Ignore auth-nocache for auth-user-pass if auth-token is pushed

2022-10-09 Thread Gert Doering
Hi, On Sat, Feb 25, 2017 at 08:40:14AM +0800, Antonio Quartulli wrote: > When the auth-token option is pushed from the server to the client, > the latter has to ignore the auth-nocache directive (if specified). > > The password will now be substituted by the unique token, therefore > it can't be

Re: [Openvpn-devel] [PATCH] Ignore auth-nocache for auth-user-pass if auth-token is pushed

2022-10-09 Thread Gert Doering
Hi, On Sun, Oct 09, 2022 at 10:13:32AM +0200, Gert Doering wrote: > This patch was still sitting "unanswered" in the list archives (though > it never landed in patchwork, as far as I can see). *sigh* More coffee on a sunday morning, it seems - this was actually merged just fine, just never recor

Re: [Openvpn-devel] [PATCH v3] Fix OpenVPN querying user/password if auth-token with user expires

2022-10-09 Thread Gert Doering
Hi, On Thu, Aug 18, 2022 at 10:26:04AM +0200, Heiko Hund wrote: > On Donnerstag, 17. Februar 2022 19:22:34 CEST Arne Schwabe wrote: > > > @@ -590,6 +590,7 @@ init_query_passwords(const struct context *c) > > /* Auth user/pass input */ > > if (c->options.auth_user_pass_file) > > { >

[Openvpn-devel] [PATCH v4] Fix OpenVPN querying user/password if auth-token with user expires

2022-10-09 Thread Arne Schwabe
The problematic behaviour happens when start a profile without auth-user-pass and connect to a server that pushes auth-token When the auth token expires OpenVPN asks for auth User and password again. The problem is that the auth_user_pass_setup sets auth_user_pass_enabled = true; This function is

[Openvpn-devel] [PATCH applied] Re: Fix OpenVPN querying user/password if auth-token with user expires

2022-10-09 Thread Gert Doering
Verified that this is just a rebase of v3, to accomodate for the auth_user_pass_setup() changes that have happened in the meantime. Recording David's and Heiko's ACK, they have done the stare-at-code and actual testing (I have run t_client tests, but they do not excercise this problem with my curr

[Openvpn-devel] [PATCH] Enable -Werror on macOS builds

2022-10-09 Thread Arne Schwabe
Signed-off-by: Arne Schwabe --- .github/workflows/build.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index f34f6a266..f7d2d3836 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -

[Openvpn-devel] [PATCH applied] Re: Enable -Werror on macOS builds

2022-10-09 Thread Gert Doering
Acked-by: Gert Doering Tested on "master + this patch" via my GitHub fork. Builds all green! https://github.com/cron2/openvpn/actions/runs/3214397115 Your patch has been applied to the master branch. commit 0ff633f750a57d0a4d48481be0bd915196a0bd32 (master) Author: Arne Schwabe Date: Sun O