Hi,
On Thu, Aug 18, 2022 at 10:26:04AM +0200, Heiko Hund wrote:
> On Donnerstag, 17. Februar 2022 19:22:34 CEST Arne Schwabe wrote:
>
> > @@ -590,6 +590,7 @@ init_query_passwords(const struct context *c)
> > /* Auth user/pass input */
> > if (c->options.auth_user_pass_file)
> > {
> > + enable_auth_user_pass();
> > #ifdef ENABLE_MANAGEMENT
> > auth_user_pass_setup(c->options.auth_user_pass_file,
> > &c->options.sc_info); #else
>
> This should be inside the #ifdef to do exactly the same as before, i.e.
> doesn't introduce side effects potentially.
Actually, it shouldn't. The #ifdef is
#ifdef ENABLE_MANAGEMENT
auth_user_pass_setup(..., foo)
#else
auth_user_pass_setup(..., NULL)
#endif
so either the enable_auth_user_pass() goes before the #ifdef, or would
need to be in both branches. So the patch is fine as it is, one can
just not see this from the hunk alone.
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
