[Openvpn-devel] [PATCH v103] dco-win: implement ovpn-dco support in P2P Windows code path

2022-08-22 Thread Lev Stipakov
From: Antonio Quartulli With this change it is possible to use ovpn-dco-win when running OpenVPN in client or P2P mode. Signed-off-by: Arne Schwabe Signed-off-by: Lev Stipakov Signed-off-by: Antonio Quartulli --- Changes from v102: * use "windows-driver ovpn-dco" without trailing "-win", si

[Openvpn-devel] [PATCH] FreeBSD networking cleanup

2022-08-22 Thread Kristof Provost via Openvpn-devel
From: Kristof Provost Address a few minor code review remarks: - use constants for the inet_ntop() buffers - replace argv_printf() + argv_printf_cat() with a single argv_printf() - net_route_v4/6 both add and remove, so adjust the error message to reflect that. Signed-off-by: Kristof Prov

[Openvpn-devel] [PATCH]: FreeBSD networking cleanup

2022-08-22 Thread Kristof Provost via Openvpn-devel
I’ll post a patch. > - any particular reason you used argv_printf() + argv_printf_cat(), >instead of just putting all into a single argv_printf() call? > Mostly that that’s what src/openvpn/networking_iproute2.c does too. I don’t have particularly strong feelings either way, so I’ll add that

Re: [Openvpn-devel] [PATCH v103] dco-win: implement ovpn-dco support in P2P Windows code path

2022-08-22 Thread Lev Stipakov
Fo the reference - I have tested the installer https://github.com/lstipakov/openvpn-build/actions/runs/2902240643 (which includes openvpn-build dco changes and openvpn master branch with this patch) on Windows 11 (VMware ESXi) - dco-win/tap-windows6/wintun drivers work as expected. I also ver

Re: [Openvpn-devel] route/iroute handling on FreeBSD

2022-08-22 Thread Kristof Provost
On 20 Aug 2022, at 16:33, Gert Doering wrote: - iroute installation works for the easy cases (--route in server.conf, --iroute with a more-specific of that in ccd/). It does not work for the nasty cases (--route and --iroute with same netbits). I will send a followup e-mail with more

[Openvpn-devel] [PATCH] t_client.sh: do not require fping6

2022-08-22 Thread Frank Lichtenheld
fping and fping6 were merged in version 4.0, released in 2017. Many recent distributions do not include the compatibility symlink anymore. So if we find fping but not fping6 do not error out but assume that fping is capable of IPv6. Signed-off-by: Frank Lichtenheld --- tests/t_client.sh.in | 13

[Openvpn-devel] [Patch v2 1/2] Update openssl_compat.h for newer LibreSSL

2022-08-22 Thread Max Fillinger
LibreSSL has added some of the functions that are defined here. However, we still need RSA_F_RSA_OSSL_PRIVATE_ENCRYPT. v2: Change ifdef condition for RSA_F_RSA_OSSL_PRIVATE_ENCRYPT. v3: Don't break WolfSSL. Signed-off-by: Max Fillinger --- src/openvpn/openssl_compat.h | 8 +--- 1 file chang

Re: [Openvpn-devel] [Patch v2 1/2] Update openssl_compat.h for newer LibreSSL

2022-08-22 Thread Arne Schwabe
Am 22.08.22 um 17:40 schrieb Max Fillinger: LibreSSL has added some of the functions that are defined here. However, we still need RSA_F_RSA_OSSL_PRIVATE_ENCRYPT. Thanks. Acked-By: Arne Schwabe ___ Openvpn-devel mailing list Openvpn-devel@lists.s

Re: [Openvpn-devel] route/iroute handling on FreeBSD

2022-08-22 Thread Gert Doering
Hi, On Mon, Aug 22, 2022 at 02:55:09PM +0200, Kristof Provost wrote: > > Now, back to FreeBSD. > > > > - our code does not try to set metrics on FreeBSD > > - my reading of route(8) does not show me anything in that direction > > (metric, preference, administrative distance, ...) > > - I

Re: [Openvpn-devel] route/iroute handling on FreeBSD

2022-08-22 Thread Kristof Provost
On 22 Aug 2022, at 20:16, Gert Doering wrote: > On Mon, Aug 22, 2022 at 02:55:09PM +0200, Kristof Provost wrote: >>> Now, back to FreeBSD. >>> >>> - our code does not try to set metrics on FreeBSD >>> - my reading of route(8) does not show me anything in that direction >>> (metric, preferen

[Openvpn-devel] [PATCH applied] Re: Update openssl_compat.h for newer LibreSSL

2022-08-22 Thread Gert Doering
I have not tested this on a recent-enough OpenBSD or OpenSSL 1.0.x (no time to build or find such a system) but I have tested on FreeBSD with 1.1.1l - unsurprisingly (the #ifdef say so) no difference. I'm a bit unsure if we need this for 2.5 - it's "long term compat" and not very intrusive, but

[Openvpn-devel] [PATCH 1/2] Github Actions: Add libreSSL actions

2022-08-22 Thread Arne Schwabe
Also we don't officially support it, it is nice to know when we break it. Signed-off-by: Arne Schwabe --- .github/workflows/build.yaml | 63 1 file changed, 63 insertions(+) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index f4246

[Openvpn-devel] [PATCH 2/2] Include libressl and macOS 12 to macOS github actions

2022-08-22 Thread Arne Schwabe
Signed-off-by: Arne Schwabe --- .github/workflows/build.yaml | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index dfa3953f0..6c2c3ef3e 100644 --- a/.github/workflows/build.yaml +++ b/.github

[Openvpn-devel] [PATCH applied] Re: Update openssl_compat.h for newer LibreSSL

2022-08-22 Thread Gert Doering
I have not tested this on a recent-enough OpenBSD or OpenSSL 1.0.x (no time to build or find such a system) but I have tested on FreeBSD with 1.1.1l - unsurprisingly (the #ifdef say so) no difference. I'm a bit unsure if we need this for 2.5 - it's "long term compat" and not very intrusive, but

[Openvpn-devel] [PATCH applied] Re: Handle EVP_MD_CTX as an opaque struct

2022-08-22 Thread Gert Doering
Same as for the previous patch, I have not tested this on a recent-enough OpenBSD or OpenSSL 1.0.x (no time to build or find such a system) but I have tested on FreeBSD with 1.1.1l and 3.0.3 - both OpenSSL builds still work fine and pass client side tests. Arne says this does not apply cleanly to

[Openvpn-devel] [PATCH applied] Re: Github Actions: Add libreSSL actions

2022-08-22 Thread Gert Doering
Acked-by: Gert Doering Looks reasonable, and more test are always good. Tested by pushing to my GH repo, and it builds all green today (no good starting with "already broken" when nobody has much interest in working on it) Your patch has been applied to the master branch. commit a79f8034cc679

[Openvpn-devel] [PATCH applied] Re: Include libressl and macOS 12 to macOS github actions

2022-08-22 Thread Gert Doering
Acked-by: Gert Doering Same thing, "looks reasonable and all green on my github repo" :-) Your patch has been applied to the master branch. commit c0724527190d864b20fb3f5725ebdcadd8900697 Author: Arne Schwabe Date: Mon Aug 22 20:41:47 2022 +0200 Include libressl and macOS 12 to macOS gi

Re: [Openvpn-devel] [PATCH applied] Re: Allow a few levels of recursion in virtual_output_callback()

2022-08-22 Thread Selva Nair
In case this request was lost, here goes again. Can we have this cherry-picked into 2.5 before the next release? Selva On Thu, Aug 11, 2022 at 4:03 PM Selva Nair wrote: > Hi, > > On Tue, Aug 2, 2022 at 8:02 AM Gert Doering wrote: > >> Acked-by: Gert Doering >> >> I cannot test this (beyond "c