In case this request was lost, here goes again. Can we have this cherry-picked into 2.5 before the next release?
Selva On Thu, Aug 11, 2022 at 4:03 PM Selva Nair <selva.n...@gmail.com> wrote: > Hi, > > On Tue, Aug 2, 2022 at 8:02 AM Gert Doering <g...@greenie.muc.de> wrote: > >> Acked-by: Gert Doering <g...@greenie.muc.de> >> >> I cannot test this (beyond "compile", but that is trivial) but the >> description in >> >> >> https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg24738.html >> >> makes sense, so allowing "a limited amount" of recursion plus actually >> logging when this is hit should make management more robust against >> overlapping timing issues aka "race conditions". >> >> Your patch has been applied to the master branch. >> > > Can we also apply this to 2.5? I see this trigerred easily with the new > persistent connection / PLAP support. I haven't figured the exact reason > but hitting reconnect or disconnect at certain instances triggers this -- > like when the connection is almost complete and the daemon is doing > slow-ish netsh commands. The same code-path is not traversed when > interactive service is in use and it seems hitting the "race condition" is > much harder in that case. > > Otherwise we have to limit these new GUI features to 2.6 which would > require a new branch in the GUI and some changes to the build process. > > In some sense this is a "bug fix" though the fix itself is a band-aid as > opposed to implementing a command queue to save these write actions instead > of dropping them. > > Selva >
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
