[Openvpn-devel] [PATCH v2] dco: disable DCO if --allow-compress yes/asym was specified

2022-08-07 Thread Antonio Quartulli
Allowing compression means that we may accept a pushable compress setting. This scenario can't work with DCO therefore disable it when compression is allowed. Signed-off-by: Antonio Quartulli --- Changes from v1: * improve wording for message --- src/openvpn/dco.c | 6 -- 1 file changed, 4

[Openvpn-devel] [PATCH v2 18/18] dco: turn supported ciphers list into a function

2022-08-07 Thread Antonio Quartulli
Other platforms may need more complex logic to decide whether a cipher is supported or not, therefore turn hardcoded list into a function that can be implemented by each platform independently. Signed-off-by: Lev Stipakov Signed-off-by: Antonio Quartulli --- Changes from v1: * rebased --- src/

[Openvpn-devel] [PATCH applied] Re: dco: disable DCO if --allow-compress yes/asym was specified

2022-08-07 Thread Gert Doering
Acked-by: Gert Doering Same functionality as v1, wording as suggested. Tested, does the job :-) Client with "--allow-compression yes --comp-lzo" -> 2022-08-07 12:20:16 Note: '--allow-compression' is not set to 'no', disabling data channel offload. Client with "--allow-compression no --comp

[Openvpn-devel] [PATCH applied] Re: dco: turn supported ciphers list into a function

2022-08-07 Thread Gert Doering
As this is really identical to 18/25 v1 (just offsets and context) I've taken the ACK from Heiko, and not done very much testing of my own, just one round of "client tests with DCO in kernel" (unchanged). Your patch has been applied to the master branch. commit f9aafa3580a84e2e74a220e6482170130f4

[Openvpn-devel] [PATCH] Cleanup: get rid of 'dynamic' argument of open_tun_generic()

2022-08-07 Thread Gert Doering
All callers of open_tun_generic() always set dynamic=true - so just get rid of it. While at it, move "int i" into the for() loop. Signed-off-by: Gert Doering --- src/openvpn/tun.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/src/openvpn/tun.c b/s