Acked-by: Gert Doering <g...@greenie.muc.de>

Same functionality as v1, wording as suggested.  Tested, does the job :-)

Client with "--allow-compression yes --comp-lzo" -> 

 2022-08-07 12:20:16 Note: '--allow-compression' is not set to 'no', disabling 
data channel offload.

Client with "--allow-compression no --comp-lzo" -> 

  Options error: Cannot set comp-lzo to '(null)', allow-compression is set to 
'no'

(this error message could use a bit of improvement, though)

Client with "--allow-compression no #--comp-lzo" -> 

 2022-08-07 12:22:15 DCO device tun7 opened


We might find ourselves returning here, and the release notes for 2.6 need
careful tending to ensure the interaction of DCO with "all these options" is
communicated really well.


Your patch has been applied to the master branch.

commit c984d0b17056f87cd580260edd2e89874c601566
Author: Antonio Quartulli
Date:   Sun Aug 7 11:53:29 2022 +0200

     dco: disable DCO if --allow-compress yes/asym was specified

     Signed-off-by: Antonio Quartulli <a...@unstable.cc>
     Acked-by: Gert Doering <g...@greenie.muc.de>
     Message-Id: <20220807095329.28819-...@unstable.cc>
     URL: 
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg24834.html
     Signed-off-by: Gert Doering <g...@greenie.muc.de>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to