Re: [Openvpn-devel] [PATCH 04/28] Add documentation for swap_hmac function

2022-04-24 Thread Gert Doering
Hi, On Fri, Apr 22, 2022 at 09:05:34PM +0200, Gert Doering wrote: > I was about to merge this as "it is easy, and does not change code", but > if we add documentation, it should be correct :-) - and this schematic > does not match my understanding of the actual code - which seems to > swap > >

[Openvpn-devel] [PATCH applied] Re: Remove tls_init_control_channel_frame_parameters wrapper function

2022-04-24 Thread Gert Doering
Acked-by: Gert Doering Easy enough, though this wrapper actually does more than usual ("turning around the argument and only passing on tas->frame"). One typo in ssl.h comment fixed. Besides the text in the commit message, this patch also removes a pre-function comment that was leftover from t

[Openvpn-devel] [PATCH] fix GitHub workflow working directories in MinGW builds

2022-04-24 Thread Marc Becker
replace hardcoded directory names with env variable version info bump pkcs11-helper version to 1.29.0 bump OpenSSL version to 1.1.1n add OpenSSL version to cache key use release file for pkcs11-helper archive use OpenSSL URL endpoint with all/current versions Signed-off-by: Marc Becker --- .gith

Re: [Openvpn-devel] [PATCH] fix GitHub workflow working directories in MinGW builds

2022-04-24 Thread Илья Шипицин
I recall that link " https://www.openssl.org/source/openssl-${OPENSSL_VERSION}.tar.gz"; becomes broken as soon as new version is released. that is the way how openssl warns you to update. "old" links are immutable. пн, 25 апр. 2022 г. в 00:27, Marc Becker : > replace hardcoded directory names wi

Re: [Openvpn-devel] [PATCH] fix GitHub workflow working directories in MinGW builds

2022-04-24 Thread Marc Becker
>"old" links are immutable.   The "old" links also do not provide the latest versions (currently 1.1.1n & 3.0.2).   While the mirrors do follow the logic of having only the latest version on top level, it seams on the main site all versions can be fetched via this pattern (tested).   This wa

[Openvpn-devel] [PATCH applied] Re: Add documentation for swap_hmac function

2022-04-24 Thread Gert Doering
Acked-by: Gert Doering I have taken the hunks from 05/28 that relate to swap_hmac (change the comment, add byte sizes to the "osid_size" comment) into this one, so this one is now factually correct, and 05(bis)/28 does no longer contain "swap_hmac" related changes. As this brings no code change,