Hi,

On Fri, Apr 22, 2022 at 09:05:34PM +0200, Gert Doering wrote:
> I was about to merge this as "it is easy, and does not change code", but
> if we add documentation, it should be correct :-) - and this schematic
> does not match my understanding of the actual code - which seems to
> swap
> 
>   [opcode + session id] [hmac + packet id]
> 
> could you double check that?  The size of the "things it swaps" is

Ah, found it.  This comment gets changed in 05/28, to the values I 
also figured out.

So, ACK on this one, will merge together with 05/ ASAPish (maybe I'll
move the "fix comment hunk" from 05 to 04).

gert

-- 
"If was one thing all people took for granted, was conviction that if you 
 feed honest figures into a computer, honest figures come out. Never doubted 
 it myself till I met a computer with a sense of humor."
                             Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany                             g...@greenie.muc.de

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to