I won't claim to understand the lifetime of the various copies of
c1.ks.auth_token_key made by code in init.c (to "to.auth_token_key"
or "other contexts") - but it seems that these all are copying
c1.ks.ssl_ctx as well - and if that can be safely free()'ed, the
other one should be fine, too. I al
Acked-by: Gert Doering
"because it makes sense" - lightly compile tested.
Your patch has been applied to the master branch.
commit 92994e682fa5f27e0c5126f16bbfae7d582c4e9c
Author: Arne Schwabe
Date: Wed May 12 15:15:03 2021 +0200
Remove explicit struct iovec check (HAVE_IOVEC)
Sig
Acked-by: Gert Doering
"because it makes sense" (we discussed this on IRC, and I couldn't
find anything in my software museum that has no getpeername() - not
even SCO Unix! - and checking for getpid() borders on ridiculous...)
Stared-at-patch, test compiled on Linux.
Your patch has been applied
Acked-by: Gert Doering
It's really the same code moved "inline", with the "if()" condition
turned around (from early-return to if(condition) { ... }).
As discussed on IRC, I have massaged the commit message a bit :-)
Your patch has been applied to the master branch.
I've toyed with the idea of
Hi,
On Wed, May 12, 2021 at 03:15:07PM +0200, Arne Schwabe wrote:
> the unit tests do not compile under windows since they are missing
> the correct ifdef guards
While I totally agree with "WE MUST HAVE MORE #IFDEF!!" (in best
OpenVPN tradition), I do not think that this is the right place or
tim
Acked-by: Gert Doering
I can't claim to understand the MSVC intricacies, but the explanation
is good, and it shouldn't break non-MSVC compiles. The dangling ";"
after an #endif is truly OpenVPN-style ugly, though... we avoid
it elsewhere by defining
#define __attribute__(x)
for MSVC builds
On 12/05/2021 15:15, Arne Schwabe wrote:
This is meant to give new users a quickstart for a useable OpenVPN
setup. Our own documentation is lacking in this regard and many often
tutorials that can be found online are often questionable in some
aspects.
Linking the invidiaul RST file on github al
>> +++ b/doc/Makefile.am
>> @@ -25,6 +25,7 @@ dist_noinst_DATA = \
>> man-sections/connection-profiles.rst \
>> man-sections/encryption-options.rst \
>> man-sections/examples.rst \
>> + man-sections/examples.rst \
>
> I suspect you intended to add doc/man-sections/example-fin
Acked-by: Gert Doering
Looks reasonable, no code changes, just moves.
Subjected this to a "make distcheck" on linux (new files...), and to
an Ubuntu18/MinGW cross build. Both passed.
Your patch has been applied to the master branch.
commit 5a571fb0f68ce6961cddfa495af2cedf3ee0e216
Author: Arne
Acked-by: Gert Doering
Documentation is good!
(The whole section could use a rewrite by a native speaker who
understands OpenVPN compression subtleties...)
Your patch has been applied to the master branch.
commit 59f640c28d61fea1efff5b1386dcf1a08dd0aad7
Author: Arne Schwabe
Date: Wed May 12
From: Lev Stipakov
pkcs11-helper is a dependency library used by OpenVPN.
So far it has been built only by mingw.
Since we're making MSVC build system a first class citizen,
we need to build depencencies with MSVC, which we do with vcpkg.
All dependencies are in vcpkg official repo, expect pkcs1
On 14/05/2021 15:57, Arne Schwabe wrote:
+++ b/doc/Makefile.am
@@ -25,6 +25,7 @@ dist_noinst_DATA = \
man-sections/connection-profiles.rst \
man-sections/encryption-options.rst \
man-sections/examples.rst \
+ man-sections/examples.rst \
I suspect you intended to add do
12 matches
Mail list logo
