Acked-by: Gert Doering <[email protected]>
I can't claim to understand the MSVC intricacies, but the explanation
is good, and it shouldn't break non-MSVC compiles. The dangling ";"
after an #endif is truly OpenVPN-style ugly, though... we avoid
it elsewhere by defining
#define __attribute__(x)
for MSVC builds, but error.h is special... the code would benefit from
a comment, though.
Your patch has been applied to the master branch.
commit ad2140e0337f99c183e732b61df03ae29bdec766
Author: Arne Schwabe
Date: Wed May 12 15:15:08 2021 +0200
Add noreturn attribute for MSVC to assert_failed method.
Signed-off-by: Arne Schwabe <[email protected]>
Acked-by: Gert Doering <[email protected]>
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg22344.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
