[Openvpn-devel] [PATCH applied] Re: Move context_auth from context_2 to tls_multi and name it multi_state

2021-04-20 Thread Gert Doering
Acked-by: Gert Doering Taking Antonio's ACK on v2, adding my own to v3. This fixes the compile problems with ENABLE_ASYNC_PUSH and the extra comment about p2p / !multi is indeed very helpful to understand why this is *exactly* the way it is. Thanks. "v3 comment" added to the commit message, st

[Openvpn-devel] [PATCH applied] Re: Fix condition to generate session keys

2021-04-20 Thread Gert Doering
Acked-by: Gert Doering Adding my own ACK because it needed a bit of whack to go in, and due to my own testing. The patch "as it is" applies to release/2.5 just fine, but conflicts with master because 2 of 3 hunks are already in, in a slightly different formatting. So, master only received the m

[Openvpn-devel] [PATCH applied] Re: In init_ssl, open the correct CRL path pre-chroot

2021-04-20 Thread Gert Doering
Looking at the code change looks reasonable. I have not tested this beyond a basic "it compiles with 2.5 as well" test. Your patch has been applied to the master and release/2.5 branch (bugfix). commit 21a0b2494e7f4f1c6325b2972743158acad4f394 (master) commit d91c14e815820d04c022677722f6f096b8877

[Openvpn-devel] [PATCH applied] Re: Abort if CRL file can't be stat-ed in ssl_init

2021-04-20 Thread Gert Doering
The actual code change looks very magical to me, and shrunk dramatically between v1 and v3 of that code :-) - but if Antonio has tested this and ACKs it, who am I to complain. I have compile-tested it, at least. Your patch has been applied to the master and release/2.5 branch (bugfix). commit 94

Re: [Openvpn-devel] [PATCH 1/3] Change options->data_channel_use_ekm to flags

2021-04-20 Thread Antonio Quartulli
Hi, On 08/04/2021 16:02, Arne Schwabe wrote: > Instead maintaining two different representation of the data channel > options in struct options and struct tls_options, use the same > flags variable that tls_options uses. > > Signed-off-by: Arne Schwabe It's a simple restyling, converting this f