Acked-by: Gert Doering <g...@greenie.muc.de> Taking Antonio's ACK on v2, adding my own to v3. This fixes the compile problems with ENABLE_ASYNC_PUSH and the extra comment about p2p / !multi is indeed very helpful to understand why this is *exactly* the way it is. Thanks. "v3 comment" added to the commit message, stray "t he" fixed.
Subjected together with the 2/2 v2 patch (only hunk 2) to the server torture chamber, and it passed nicely... Test sets succeeded: 1 1a 1b 1c 1d 1e 2 2a 2b 2c 2g 2d 2e 2f 2z1 2z2 3 4 4a 4b 5 5a 5b 5c 5d 5v1 5v2 5v3 5w1 5w2 5w3 5w4 5x1 5x2 5x3 5x4 6 7 7x 7y 8 8a 9 9a. Backport to 2.5 was done because it is required for the 2/2 bugfix. 2.5 looks sufficiently different in context and push.c that there were quite a few conflicts and one extra "context_auth" to adjust - but nothing that wasn't fairly straightforward to sort out. 2.5 of course subjected to the same tests... Your patch has been applied to the master and release/2.5 branch. commit 0767d5b447044e4cdcfd198058aef1f85f63bbe6 (master) commit 145110101b70599cb9adcf4ed071856daac9c8af (release/2.5) Author: Arne Schwabe Date: Sun Apr 18 18:01:11 2021 +0200 Move context_auth from context_2 to tls_multi and name it multi_state Signed-off-by: Arne Schwabe <a...@rfc2549.org> Acked-by: Antonio Quartulli <anto...@openvpn.net> Acked-by: Gert Doering <g...@greenie.muc.de> Message-Id: <20210418160111.1494779-1-a...@rfc2549.org> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg22155.html Signed-off-by: Gert Doering <g...@greenie.muc.de> -- kind regards, Gert Doering _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel