[Openvpn-devel] [PATCH applied] Re: Also restore/save compress related options in reconnects

2021-04-17 Thread Gert Doering
Acked-by: Gert Doering Stared-at-code (looks good), client side tested with the usual parcours (good), and also tested with my two known-weird/broken test cases for "compress not restored" (fixed!). Your patch has been applied to the master branch. I tried to apply it to release/2.5, but the r

[Openvpn-devel] [PATCH applied] Re: Also restore/save route-gatreway options in reconnects

2021-04-17 Thread Gert Doering
Acked-by: Gert Doering Stared-at-code (looks good) and subjected to the test rig that breaks (server with topology subnet, pushing route-gateway, SIGUSR1, advance to server that uses top net30, stuck route-gateway breaks route installation). Good :-) Backport to 2.5 was fairly trivial (rename

[Openvpn-devel] [PATCH] Repair --secret depreciation warning.

2021-04-17 Thread Gert Doering
commit 60f5889ae formally depreciated use of configs without either "tls-client" or "tls-server" - but got the booleans wrong. Fix. Signed-off-by: Gert Doering --- src/openvpn/options.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpn/options.c b/src/openvpn/optio

Re: [Openvpn-devel] [PATCH] Repair --secret depreciation warning.

2021-04-17 Thread Antonio Quartulli
Hi, On 17/04/2021 12:05, Gert Doering wrote: > commit 60f5889ae formally depreciated use of configs without either depreciated -> deprecated (no?) > "tls-client" or "tls-server" - but got the booleans wrong. > > Fix. > > Signed-off-by: Gert Doering Makes sense. The warning should be displaye

[Openvpn-devel] [PATCH applied] Re: Repair --secret deprecation warning.

2021-04-17 Thread Gert Doering
Patch has been applied to the master branch. Wording fixed as requested ("depreciation" is a valid term, but refers to "financial value diminishes over time") Tested, of course - now only the p2p test warns (as opposed to "all warn"), and that's to be expected :-) commit 85080921096fe60c6956b1e0

[Openvpn-devel] [PATCH applied] Re: Remove LibreSSL specific defines not needed for modern LibreSSL

2021-04-17 Thread Gert Doering
Getting rid of #ifdef is always good :-) - tested on OpenBSD 6.8 ("just to be sure"), works. On OpenBSD 6.5, it fails at link time (LibreSSL 2.9.1, RSA_meth_set_pub_enc and other RSA_meth* functions missing). So, no more support for that (already end-of-life) OpenBSD version. FreeBSD ports now h