Hi,
On 17/04/2021 12:05, Gert Doering wrote:
> commit 60f5889ae formally depreciated use of configs without either
depreciated -> deprecated (no?)
> "tls-client" or "tls-server" - but got the booleans wrong.
>
> Fix.
>
> Signed-off-by: Gert Doering <g...@greenie.muc.de>
Makes sense.
The warning should be displayed when both options are not specified.
With the current logic the warning pops up all the time, except when
both options are specified (not sure this is even allowed..). And
clearly not what we wanted :-)
Acked-by: Antonio Quartulli <anto...@openvn.net>
> ---
> src/openvpn/options.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/openvpn/options.c b/src/openvpn/options.c
> index 3dd22d52..ef854c76 100644
> --- a/src/openvpn/options.c
> +++ b/src/openvpn/options.c
> @@ -2541,7 +2541,7 @@ options_postprocess_verify_ce(const struct options
> *options,
> msg(M_USAGE, "specify only one of --tls-server, --tls-client, or
> --secret");
> }
>
> - if (!options->tls_server || !options->tls_client)
> + if (!options->tls_server && !options->tls_client)
> {
> msg(M_INFO, "DEPRECATION: No tls-client or tls-server option in "
> "configuration detected. OpenVPN 2.7 will remove the "
>
--
Antonio Quartulli
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
