Your patch has been applied to the master and release/2.4 branch. Thanks.
commit a35d517f4893b3967783ad7926a7edd08f9f59d3 (master)
commit 4e36eb913dfe5b4e4d9c0c0637f480c5b9f63e33 (release/2.4)
Author: Thomas Quinot
Date: Fri Feb 1 21:43:48 2019 +0100
Fix documentation of tls-verify script
20190117155829.ga92...@greenie.muc.de>
References: <20190224181252.43996-1-si...@rozman.si
20190117155829.ga92...@greenie.muc.de>
Acked-by: Gert Doering
"Does what I asked for and looks reasonable" ;-) - thanks.
Your patch has been applied to the master branch.
commit f75351da2974dac10baca5fa8
20190117155829.ga92...@greenie.muc.de>
References: <20190224181504.38328-1-si...@rozman.si
20190117155829.ga92...@greenie.muc.de>
Acked-by: Gert Doering
Trival but useful :)
Your patch has been applied to the master branch.
commit 890f9a85ca86fbba678fddb2e589a0180a6f1784
Author: Simon Rozman
D
20190117155829.ga92...@greenie.muc.de>
References: <20190224181400.42524-1-si...@rozman.si
20190117155829.ga92...@greenie.muc.de>
Acked-by: Gert Doering
Thanks :-) (not only NULL checks, but calloc() as well!)
Test built on ubuntu1604/mingw.
Your patch has been applied to the master branch.
Hi,
"whatever happened here", this was supposed to thread...
gert
On Thu, Feb 28, 2019 at 03:54:15PM +0100, Gert Doering wrote:
> 20190117155829.ga92...@greenie.muc.de>
> References: <20190224181252.43996-1-si...@rozman.si
> 20190117155829.ga92...@greenie.muc.de>
>
> Acked-by: Gert Doering
>
(Re-send with proper references - my mailer and my git tools hate
each other today)
Acked-by: Gert Doering
Thanks :-) (not only NULL checks, but calloc() as well!)
Test built on ubuntu1604/mingw.
Your patch has been applied to the master branch.
commit fbb5d6c56b5586ffd3731fc76e706131b635be
(Re-send with proper references - my mailer and my git tools hate
each other today)
Acked-by: Gert Doering
Trival but useful :)
Your patch has been applied to the master branch.
commit 890f9a85ca86fbba678fddb2e589a0180a6f1784
Author: Simon Rozman
Date: Sun Feb 24 19:15:04 2019 +0100
A
(Re-send with proper references - my mailer and my git tools hate
each other today)
Acked-by: Gert Doering
"Does what I asked for and looks reasonable" ;-) - thanks.
Your patch has been applied to the master branch.
commit f75351da2974dac10baca5fa83c18be7f27c73cf
Author: Simon Rozman
Date:
Acked-by: Gert Doering
(Basically just reworking if/goto into if/else, plus more verbose comments.
"Git show -w --color-moved=zebra" helps in seeing "nothing really changed")
Your patch has been applied to the master branch.
commit 197f8076e43534f3dfe50e3c638143c38f4bad7f
Author: Simon Rozman
D
Hi,
never replied to this one...
On Sun, Jan 20, 2019 at 02:54:01PM +, Simon Rozman wrote:
[..]
> Wow, this made a nice text to start the developer documentation of MSI
> setup. If it was understandable enough. :)
It was understandable and matched what I had to guess out of reading
quite a b
Acked-by: Gert Doering
Trivial change, but very useful :-) - thanks.
Your patch has been applied to the master branch.
commit 5a05352f0ae06d2f79072fdc86370f279ed84074
Author: Simon Rozman
Date: Sun Feb 24 19:55:00 2019 +0100
Add developer notes URL for openvpnmsica.dll
Signed-off-
Acked-by: Gert Doering
Thanks for the change. I have *not* tested it, just test compiled it
(the usual ubuntu 16.04/mingw combo), but staring at the code, this look
reasonable. Actually the change seems to make the code *more simple*
(in FindTAPInterfaces() ) which is always welcome...
Your pa
Acked-by: Gert Doering
.. for the reasons given (as this is mostly removing non-code files,
easy to review). Thanks for the documentation pointers.
I have tested with "make distcheck" that autoconf still agrees with
you on "which files should be there for packaging" (it does).
Your patch has
Acked-by: Gert Doering
Thanks. I have not tested the various error conditions, but the code
makes sense to me and it passes compile and t_client tests (which use
--up here), so it's not breaking stuff in fundamental and non-obvious
ways.
(Since David was mostly happy with the v1 approach except
Hi,
On Thu, Feb 28, 2019 at 12:25 PM Gert Doering wrote:
> Acked-by: Gert Doering
>
> Thanks. I have not tested the various error conditions, but the code
> makes sense to me and it passes compile and t_client tests (which use
> --up here), so it's not breaking stuff in fundamental and non-obv
Hi,
On Thu, Feb 28, 2019 at 12:33:46PM -0500, Selva Nair wrote:
> On Thu, Feb 28, 2019 at 12:25 PM Gert Doering wrote:
>
> > Your patch has been applied to the master branch - it won't apply to
> > 2.4 as we have no "run_command.*" there yet. Shall we cherrypick
> > bf97c00f7dba4 and 253f015558
While the existing code is not wrong and will never cause an overflow,
it will copy (on a too-long source string) "maxlen" bytes to dest, and
then overwrite the last byte just copied with "0" - which causes a
warning in gcc 9 about filling the target buffer "up to the end,
with no room for a traili
Hi,
On 28/02/2019 19:51, Gert Doering wrote:
> While the existing code is not wrong and will never cause an overflow,
> it will copy (on a too-long source string) "maxlen" bytes to dest, and
> then overwrite the last byte just copied with "0" - which causes a
> warning in gcc 9 about filling the t
From: Selva Nair
- Add a new return value (-2) for openvpn_execve() when external
program execution is not allowed due to a low script-security
setting.
- Add a corresponding error message
Errors and warnings in such cases will now display as
"WARNING: failed running command () :" followed
19 matches
Mail list logo
