Hi, On Thu, Feb 28, 2019 at 12:33:46PM -0500, Selva Nair wrote: > On Thu, Feb 28, 2019 at 12:25 PM Gert Doering <g...@greenie.muc.de> wrote: > > > Your patch has been applied to the master branch - it won't apply to > > 2.4 as we have no "run_command.*" there yet. Shall we cherrypick > > bf97c00f7dba4 and 253f015558 to get there? Or do you want to do a > > 2.4 version of the patch? > > Would require more cherry-picks than that, or some manual edits, isn't it?
Yes, as we also have uncrustify patches that affect neighboring code.
> I can send a patch for 2.4 -- would you prefer the same as this --
> i.e with switch(stat) in misc.c and and preprocessor macros in misc.h
> or a simpler, return code = -2 and error message as in version 1?
I think we should have the same code (so, with the switch()), just in
misc.c - when we come here next time, at least it will be the same code,
not "something completely different".
thanks,
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
