Re: [Openvpn-devel] [PATCH] Add support for OpenSSL TLS 1.3 when using management-external-key

2018-10-17 Thread Arne Schwabe
Am 17.10.18 um 05:15 schrieb Selva Nair: > Hi, > > Not a review, but some thoughts: > > On Sun, Oct 7, 2018 at 5:59 PM Arne Schwabe wrote: >> >> For TLS 1.0 to 1.2 OpenSSL calls us and requires a PKCS1 padded >> response, for TLS 1.3 it requires to an unpadded response. Since we >> can PCKS1 pad

Re: [Openvpn-devel] [PATCH] Windows: Set interface IPv6 prefix length when configuring address

2018-10-17 Thread David Sommerseth
On 16/10/18 23:48, Selva Nair wrote: > Hi, > > Going through patchworks noticed this. > > Thankfully this never got committed so here goes a retraction. > > On Sun, Jan 21, 2018 at 1:45 PM Selva Nair > wrote: > > Hi, > > I'm on a reviewing spree (doing my

Re: [Openvpn-devel] [PATCH] Windows: Set interface IPv6 prefix length when configuring address

2018-10-17 Thread Gert Doering
Hi, On Tue, Oct 16, 2018 at 05:48:29PM -0400, Selva Nair wrote: > Going through patchworks noticed this. > > Thankfully this never got committed so here goes a retraction. > > On Sun, Jan 21, 2018 at 1:45 PM Selva Nair wrote: > > > Hi, > > > > I'm on a reviewing spree (doing my penance), so he

Re: [Openvpn-devel] [PATCH] Windows: Set interface IPv6 prefix length when configuring address

2018-10-17 Thread Selva Nair
Hi, On Wed, Oct 17, 2018 at 8:07 AM Gert Doering wrote: > Hi, > > On Tue, Oct 16, 2018 at 05:48:29PM -0400, Selva Nair wrote: > > Going through patchworks noticed this. > > > > Thankfully this never got committed so here goes a retraction. > > > > On Sun, Jan 21, 2018 at 1:45 PM Selva Nair wrot

Re: [Openvpn-devel] [PATCH] Add support for OpenSSL TLS 1.3 when using management-external-key

2018-10-17 Thread Selva Nair
Hi, On Wed, Oct 17, 2018 at 6:00 AM Arne Schwabe wrote: > > Am 17.10.18 um 05:15 schrieb Selva Nair: > > Hi, > > > > Not a review, but some thoughts: > > > > On Sun, Oct 7, 2018 at 5:59 PM Arne Schwabe wrote: > >> > >> For TLS 1.0 to 1.2 OpenSSL calls us and requires a PKCS1 padded > >> response