Hi, On Tue, Oct 16, 2018 at 05:48:29PM -0400, Selva Nair wrote: > Going through patchworks noticed this. > > Thankfully this never got committed so here goes a retraction. > > On Sun, Jan 21, 2018 at 1:45 PM Selva Nair <selva.n...@gmail.com> wrote: > > > Hi, > > > > I'm on a reviewing spree (doing my penance), so here goes.. > > > > Thanks for the patch > > > > On Tue, Jan 9, 2018 at 2:16 AM, Eyal Birger <eyal.bir...@gmail.com> wrote: > > > Address prefix length defaults to /64 on Windows. This change allows > > using > > > Windows clients in setups that use a different prefix length.
I had this on "I need to do more testing with this", which is why it never proceeded - there might be unintended side effects, so I wanted to do more detailed testing with "netsh" and with "iservice" backends, and different prefix lengths etc. Also, I had the suspicion that if we actually set a prefix length, it will lead to local ND traffic which the tap driver won't answer (it will only answer fe80::8) thus causing a "black hole route" for the tap subnet... [..] > Though this works in my tests I want to retract this ACK. > > Apart from possible issues due to the appearance of the onlink route in > some cases, I think the correct approach going forward is to stop using > netsh and use the IP helper API for such tasks. And do it in the same way > as done using the service. > > Un-Acked-by: Selva Nair <selva.n...@gmail.com> :) Thanks :-) We'll definitely need to look into this more closely. gert -- "If was one thing all people took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel