Re: [Openvpn-devel] [PATCH] Extend push-remove to also handle 'ifconfig'.

2018-06-30 Thread Antonio Quartulli
Hi, thanks for taking care of this! IPv4 settings should all be treated like others and never "assumed to be there all the time" anymore :) On 30/06/18 01:45, Gert Doering wrote: > Push-remove (introduced in commit 970312f1850) did not handle "ifconfig" > yet, as both "ifconfig" and "ifconfig-ipv

[Openvpn-devel] [PATCH] Remove deprecated plugin functions from code samples

2018-06-30 Thread Greg Cox
While writing up a plugin, I found that the sample plugin code was using openvpn_plugin_open_v1. Since that and openvpn_plugin_func_v1 are listed as 'deprecated' in openvpn-plugin.h, it made sense to me that you shouldn't list those functions as sample code for others to clone. This edits only sa

Re: [Openvpn-devel] [PATCH] Remove deprecated plugin functions from code samples

2018-06-30 Thread Antonio Quartulli
Hi, On 01/07/18 00:58, Greg Cox wrote: > While writing up a plugin, I found that the sample plugin code was using > openvpn_plugin_open_v1. Since that and openvpn_plugin_func_v1 are listed > as 'deprecated' in openvpn-plugin.h, it made sense to me that you shouldn't > list those functions as samp

Re: [Openvpn-devel] [PATCH] Remove deprecated plugin functions from code samples

2018-06-30 Thread Gert Doering
Hi, On Sun, Jul 01, 2018 at 01:49:26AM +0800, Antonio Quartulli wrote: [..] > did you concatenate two patches? or what happened? It seems that the > part after this is not recognised as proper patch. If the patch gets an ACK otherwise, I can (usually) fix this on commit. gert -- "If was one t

Re: [Openvpn-devel] [PATCH] Remove deprecated plugin functions from code samples

2018-06-30 Thread Greg Cox
On Sat, Jun 30, 2018 at 5:49 PM, Antonio Quartulli wrote: > I'd remove the last paragraph and the greetings from the commit message. > But this might be done at commit time. > ​It was unclear how to handle "explain what I'm wanting" in one mail. Sorry. ​ > did you concatenate two patches? or wh

Re: [Openvpn-devel] [PATCH] Remove deprecated plugin functions from code samples

2018-06-30 Thread Yovie Ramadhan
Minggu, 01 Juli 2018, Antonio Quartulli menulis: > Hi, > > On 01/07/18 00:58, Greg Cox wrote: > > While writing up a plugin, I found that the sample plugin code was using > > openvpn_plugin_open_v1. Since that and openvpn_plugin_func_v1 are listed > > as 'deprecated' in openvpn-plugin.h, it made

Re: [Openvpn-devel] [PATCH] Remove deprecated plugin functions from code samples

2018-06-30 Thread Yovie Ramadhan
Minggu, 01 Juli 2018, Yovie Ramadhan menulis: > > > Minggu, 01 Juli 2018, Antonio Quartulli menulis: > >> Hi, >> >> On 01/07/18 00:58, Greg Cox wrote: >> > While writing up a plugin, I found that the sample plugin code was using >> > openvpn_plugin_open_v1. Since that and openvpn_plugin_func_v1

Re: [Openvpn-devel] [PATCH] Remove deprecated plugin functions from code samples

2018-06-30 Thread Antonio Quartulli
On 01/07/18 05:08, Greg Cox wrote: > On Sat, Jun 30, 2018 at 5:49 PM, Antonio Quartulli wrote: > >> I'd remove the last paragraph and the greetings from the commit message. >> But this might be done at commit time. >> > > ​It was unclear how to handle "explain what I'm wanting" in one mail. > S