Your patch has been applied to the master branch.
commit c5108260b3699ab01638452ef3c9bef5193e265a
Author: Ilya Shipitsin
Date: Mon May 28 00:00:57 2018 +0500
travis-ci: cleanup, refactor, upgrade ssl libraries
Signed-off-by: Ilya Shipitsin
Acked-by: Steffan Karger
Message
Hi,
On Sat, Jun 23, 2018 at 11:13:07AM +0800, Antonio Quartulli wrote:
> > Very likely. It would be nice to find the on-link route that triggers that
> > code
> > path to ensure it doesn't cause any other issues.
>
> My server was on the same LAN (connecting via v4) as the client - should
> that
Acked-by: Gert Doering
The code is trivially correct, and it does what it says on the lid :-)
- and to verify, I've added a unit test to test_argv.c - attached below,
we might consider adding something like this, or something more elaborate
for all supported argv*() arguments...
Your patch has
Some basic integer tests to verify signed, unsigned and
long unsigned (2^33) printing.
Signed-off-by: Gert Doering
---
tests/unit_tests/openvpn/test_argv.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tests/unit_tests/openvpn/test_argv.c
b/tests/unit_tests/openvpn/te
Hi,
On Sat, Jun 23, 2018 at 02:15:03PM +0200, Gert Doering wrote:
> Some basic integer tests to verify signed, unsigned and
> long unsigned (2^33) printing.
Ditch that patch... this only works on 64bit systems.
What I wanted to see is "yes, it really does long math", but on systems
where sizeof(
Hi,
On Sat, Jun 23, 2018 at 1:31 PM, Gert Doering wrote:
> Hi,
>
> On Sat, Jun 23, 2018 at 02:15:03PM +0200, Gert Doering wrote:
> > Some basic integer tests to verify signed, unsigned and
> > long unsigned (2^33) printing.
>
> Ditch that patch... this only works on 64bit systems.
>
Most 64 bit
Hi,
On 24/06/18 02:08, Selva Nair wrote:
>> Or shall I just have it print "1", so we know "%lu works and prints its
>> argument nicely"?
>>
>
> That should be enough, but we could get fancy and use -1L and compare
> the result against sprintf(str, "%lu", -1L)
>
I just recommended something simi
Some basic integer tests to verify signed, unsigned and
long unsigned (2^33) printing.
Signed-off-by: Gert Doering
--
v2: test %lu with "1" as windows and linux/i386 do not have 64 bit long
---
tests/unit_tests/openvpn/test_argv.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff
Hi,
On Sun, Jun 24, 2018 at 02:12:29AM +0800, Antonio Quartulli wrote:
> > That should be enough, but we could get fancy and use -1L and compare
> > the result against sprintf(str, "%lu", -1L)
>
> I just recommended something similar on IRC.
> I think it would make sense to "validate" argv_printf
From: Antonio Quartulli
This patch ensures that the TAP driver on a windows host is still
configured, even though no IPv4 has been provided.
In this case the TAP driver ioctl will be invoked with a fake
0.0.0.0/0.0.0.0 IPv4 which will simply start the interface and
get it to a working state.
Tr
Acked-by: Gert Doering
Took us a while to get here, but here we are :-) - it compiles! (And it
actually *works* - tested v4+v6 and v6-only on Win7/64 - with iservice - and
it does the right thing and logs useful messages)
Your patch has been applied to the master branch.
commit 125e9df9539a0d
Hi,
This is good enough, but (there is always a but :)
On Sat, Jun 23, 2018 at 2:15 PM, Gert Doering wrote:
> Some basic integer tests to verify signed, unsigned and
> long unsigned (2^33) printing.
>
That 2^33 still lurking in the commit message could go..
>
> Signed-off-by: Gert Doering
>
Some basic integer tests to verify signed, unsigned and
long unsigned (1L) printing.
Signed-off-by: Gert Doering
--
v2: test %lu with "1" as windows and linux/i386 do not have 64 bit long
v3: fix 2^33 in commit message, use "1L" for proper data type (Selva)
---
tests/unit_tests/openvpn/test_argv
Hi,
On Sat, Jun 23, 2018 at 3:15 PM, Gert Doering wrote:
> Some basic integer tests to verify signed, unsigned and
> long unsigned (1L) printing.
>
> Signed-off-by: Gert Doering
> --
> v2: test %lu with "1" as windows and linux/i386 do not have 64 bit long
> v3: fix 2^33 in commit message, use
Patch has been applied to the master and release/2.4 branch.
commit 4376805d8fd2a5d4a3a7c5e4f60948a3ef76ff3b (master)
commit 6b27704dafcb60e995601178bbcfac751207e93e (release/2.4)
Author: Gert Doering
Date: Sat Jun 23 21:15:38 2018 +0200
Add %d, %u and %lu tests to test_argv unit tests.
From: Antonio Quartulli
With this change a server is allowed to allocate an
IPv6-only pool. This is required to make it capable
of managing an IPv6-only tunnel.
Trac: #208
Signed-off-by: Antonio Quartulli
---
Changes from v2:
- patchset rebased on top of current master
- introduce missing cond
From: Antonio Quartulli
Until now OpenVPN has not allowed to specify --server-ipv6
if no --server was also set. This constraint comes from the
fact that most of the IPv6 logic (i.e. ifconfig-pool handling)
relied on IPv4 components to be activated and configured as
well.
Now that the IPv6 code p
Hi,
On 28/05/18 03:00, Ilya Shipitsin wrote:
> -- MBEDTLS_VERSION="2.5.1"
> +- MBEDTLS_VERSION="2.8.0"
I know travis-ci currently is caching both the downloaded tarball and
the built library, therefore my question: what will happen to
mbedtls-2.5.1-*? Will that be wiped after some time? O
Someone who has admin rights, can purge the cache
On Sun, Jun 24, 2018, 8:28 AM Antonio Quartulli wrote:
> Hi,
>
> On 28/05/18 03:00, Ilya Shipitsin wrote:
> > -- MBEDTLS_VERSION="2.5.1"
> > +- MBEDTLS_VERSION="2.8.0"
>
> I know travis-ci currently is caching both the downloaded tarball
Hi,
On 24/06/18 04:08, Antonio Quartulli wrote:
> From: Antonio Quartulli
>
> With this change a server is allowed to allocate an
> IPv6-only pool. This is required to make it capable
> of managing an IPv6-only tunnel.
After discussing with Gert, I'd say that maybe this last sentence can be
rem
20 matches
Mail list logo
