Re: [Openvpn-devel] [PATCH] OpenSSL: Fix compilation with deprecated APIs disabled on 1.1

2018-06-21 Thread Rosen Penev
On Tue, Jun 19, 2018 at 10:00 PM Gert Doering wrote: > > Hi, > > On Tue, Jun 19, 2018 at 09:46:50PM -0700, Rosen Penev wrote: > > Signed-off-by: Rosen Penev > > --- > > src/openvpn/crypto_openssl.c | 9 + > > src/openvpn/ssl_openssl.c| 32 +++- > >

[Openvpn-devel] [PATCH] openvpn: Add missing OpenSSL includes

2018-06-21 Thread Rosen Penev
These get included when deprecated APIs are enabled. This is true on at least version 1.0.2 and 1.1.0. Without deprecated APIs, OpenVPN fails to compile. Signed-off-by: Rosen Penev --- ...ilation-with-deprecated-APIs-disable.patch | 148 ++ src/openvpn/ssl_openssl.c

Re: [Openvpn-devel] [PATCH] openvpn: Add missing OpenSSL includes

2018-06-21 Thread Antonio Quartulli
Hi, On 22/06/18 09:49, Rosen Penev wrote: > These get included when deprecated APIs are enabled. This is true on at > least version 1.0.2 and 1.1.0. > > Without deprecated APIs, OpenVPN fails to compile. > > Signed-off-by: Rosen Penev > --- > ...ilation-with-deprecated-APIs-disable.patch | 148

Re: [Openvpn-devel] [PATCH] openvpn: Add missing OpenSSL includes

2018-06-21 Thread Rosen Penev
On Thu, Jun 21, 2018 at 6:59 PM Antonio Quartulli wrote: > > Hi, > > On 22/06/18 09:49, Rosen Penev wrote: > > These get included when deprecated APIs are enabled. This is true on at > > least version 1.0.2 and 1.1.0. > > > > Without deprecated APIs, OpenVPN fails to compile. > > > > Signed-off-by

[Openvpn-devel] [PATCHv2] openvpn: Add missing OpenSSL includes

2018-06-21 Thread Rosen Penev
These get included when deprecated APIs are enabled. This is true on at least version 1.0.2 and 1.1.0. Without deprecated APIs, OpenVPN fails to compile. Signed-off-by: Rosen Penev --- src/openvpn/ssl_openssl.c| 9 + src/openvpn/ssl_verify_openssl.c | 1 + 2 files changed, 10 in

Re: [Openvpn-devel] [PATCH 01/10] Add crypto_pem_{encode,decode}()

2018-06-21 Thread Steffan Karger
Hi Antonio, Thanks for the review! On 15-06-18 09:03, Antonio Quartulli wrote: > On 08/12/17 20:07, Steffan Karger wrote: >> Needed for tls-crypt-v2, but isolated enough to be reviewed as a separate >> patch. >> >> The encode API allocates memory, because it fits our typical gc-oriented >> code p