Re: [Openvpn-devel] travis builds

it started to happen after travis-ci image was updated to clang-5.0, somehow it does not work well with ccache (that's why we removed ccache recently) 2018-01-15 22:28 GMT+05:00 Selva Nair : > Hi, > > Out of the 12 or so jobs we have in the travis build matrix a few > sometime fail with "write er

Re: [Openvpn-devel] [PATCH v2 2/3] OpenSSL: remove some EVP_PKEY type checks

Hi, On Tue, Jan 16, 2018 at 01:56:11AM +0100, Emmanuel Deloget wrote: > 3) rework it as proposed in the patch > > RSA *rsa = NULL; > if ((rsa = EVP_PKEY_get0_RSA(pkey)) != NULL) { ... } I do not particularily like assignments in if() clauses, especially when the variable is declared right above

[Openvpn-devel] Topics for the community meeting (Wed, 17th Jan 2018)

Hi, We're going to have an IRC meeting starting at 11:30 CET (10:30 UTC) on #openvpn-meeting irc.freenode.net. You do not have to be logged in to Freenode to join the channel. Current topic list along with basic information is here:

Re: [Openvpn-devel] travis builds

On Tue, Jan 16, 2018 at 3:16 AM, Илья Шипицин wrote: > > > 2018-01-15 22:28 GMT+05:00 Selva Nair : >> >> Hi, >> >> Out of the 12 or so jobs we have in the travis build matrix a few >> sometime fail with "write error" (happened a number of times for some >> local feature branches). On restarting on

[Openvpn-devel] [PATCH] Replace buffer backed strings for management_android_control with simple stack variables

This simplifies the code a bit and also silences compiler warnings about uint8_t pointers passed to char pointers without cast --- src/openvpn/route.c | 14 +++--- src/openvpn/tun.c | 12 ++-- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/src/openvpn/route.c b

Re: [Openvpn-devel] [PATCH 2/3] Allow external EC key through --management-external-key

Am 14.01.18 um 20:44 schrieb selva.n...@gmail.com: > From: Selva Nair > > - This automatically supports EC certificates through > --management-external-cert > - EC signature request from management has the same format > as for rsa with >RSA_SIGN replaced by >ECDSA_SIGN > Response should be

Re: [Openvpn-devel] [PATCH 1/3] Refactor ssl_openssl.c in prep for external EC key support

Am 14.01.18 um 20:44 schrieb selva.n...@gmail.com: > From: Selva Nair > > - Move setting of key method callbacks into a function > > No change in functionality. > > This patch is fairly simple and does exactly what it says. Acked-By: Arne Schwabe -

Re: [Openvpn-devel] [PATCH 3/3] Document management request >ECDSA_SIGN and response ecdsa-sig

Am 14.01.18 um 20:44 schrieb selva.n...@gmail.com: > From: Selva Nair > > Signed-off-by: Selva Nair > --- > doc/management-notes.txt | 30 ++ > 1 file changed, 30 insertions(+) > > diff --git a/doc/management-notes.txt b/doc/management-notes.txt > index a9ba18a..e2e

Re: [Openvpn-devel] [PATCH 2/3] Allow external EC key through --management-external-key

Hi, Wow that was fast :) Thanks for the review. I'll provide a v2, but some quick remarks/rfc On Tue, Jan 16, 2018 at 5:40 PM, Arne Schwabe wrote: > Am 14.01.18 um 20:44 schrieb selva.n...@gmail.com: >> From: Selva Nair >> >> - This automatically supports EC certificates through >> --managem

Re: [Openvpn-devel] [PATCH 2/3] Allow external EC key through --management-external-key

Hi, > On Tue, Jan 16, 2018 at 5:40 PM, Arne Schwabe wrote: >> Am 14.01.18 um 20:44 schrieb selva.n...@gmail.com: >>> From: Selva Nair >>> >>> - This automatically supports EC certificates through >>> --management-external-cert >>> - EC signature request from management has the same format >>>

Re: [Openvpn-devel] [PATCH 3/3] Document management request >ECDSA_SIGN and response ecdsa-sig

Hi, FWIW, some remarks on the hash and the signature below. On Tue, Jan 16, 2018 at 5:23 PM, Arne Schwabe wrote: > Am 14.01.18 um 20:44 schrieb selva.n...@gmail.com: >> From: Selva Nair >> >> Signed-off-by: Selva Nair >> --- >> doc/management-notes.txt | 30 ++ >>