Hi,
On Tue, Jan 16, 2018 at 01:56:11AM +0100, Emmanuel Deloget wrote:
> 3) rework it as proposed in the patch
>
> RSA *rsa = NULL;
> if ((rsa = EVP_PKEY_get0_RSA(pkey)) != NULL) { ... }
I do not particularily like assignments in if() clauses, especially when
the variable is declared right above it. So if we go for (3), my
favourite would be
RSA *rsa = EVP_PKEY_get0_RSA(pkey);
if (rsa != NULL) { ... }
but this is just a side remark. The question on "1, 2 or 3" I'll defer
to you folks that are maintaing this code (Steffan and Selva, mostly :) ).
gert
--
now what should I write here...
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
