Re: [Openvpn-devel] [PATCH 3/5 v2] buffer_list_aggregate_separator(): don't exceed max_len

2017-12-28 Thread Antonio Quartulli
Hi, On 09/11/17 22:02, Steffan Karger wrote: > buffer_list_aggregate_separator() would merge buffer_list entries until it > had exceeded the provided max_len, instead of stopping *before* exceeding > the max value. > > Signed-off-by: Steffan Karger > --- > v2: rebase on 1/5 v2 (other patches sho

Re: [Openvpn-devel] [PATCH 4/5] buffer_list_aggregate_separator(): prevent 0-byte malloc

2017-12-28 Thread Antonio Quartulli
Hi, On 01/07/17 20:54, Steffan Karger wrote: > As pointed out in finding OVPN-05 of the cryptograpy engineering audit > (funded by Private Internet Access), buffer_list_aggregate_separator() > could perform a 0-byte malloc when called with a list of 0-length buffers > and a "" separator. If other

Re: [Openvpn-devel] [PATCH 2/5 v2] buffer_list_aggregate_separator(): update list size after aggregating

2017-12-28 Thread Antonio Quartulli
Hi, the patch looks good and finally gets rid of some FIXMEs in the buffer unit-test. However, the field fixed by this patch is not really used anywhere, thus no real logic flaw is being corrected (Steffan, correct me if I am wrong). For this reason, I think that backporting this patch to older