Hi, the patch looks good and finally gets rid of some FIXMEs in the buffer unit-test.
However, the field fixed by this patch is not really used anywhere, thus no real logic flaw is being corrected (Steffan, correct me if I am wrong). For this reason, I think that backporting this patch to older releases is entirely up to the maintainers. On 11/12/17 19:41, Steffan Karger wrote: > After aggregating a buffer_list, the size should be adjusted accordingly. > > Signed-off-by: Steffan Karger <steffan.kar...@fox-it.com> Acked-by: Antonio Quartulli <a...@unstable.cc> except for a little style issue remarked below: > --- > v2: rebase on master > > src/openvpn/buffer.c | 1 + > tests/unit_tests/openvpn/test_buffer.c | 15 +++++---------- > 2 files changed, 6 insertions(+), 10 deletions(-) > > diff --git a/src/openvpn/buffer.c b/src/openvpn/buffer.c > index ecd3b17..28ac508 100644 > --- a/src/openvpn/buffer.c > +++ b/src/openvpn/buffer.c > @@ -1257,6 +1257,7 @@ buffer_list_aggregate_separator(struct buffer_list *bl, > const size_t max, const > e = next; > } > bl->head = f; > + bl->size -= count-1; the '-' sign should be surrounded by spaces. Cheers, -- Antonio Quartulli
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
