On Sat, Nov 04 2017, Gert Doering wrote:
> ACK, thanks. Reviewed by "staring at the code" (changes are only what it
> says on the tin), compiling with clang and gcc (no format related warnings),
> and running tests, of course :-)
Cool, thank you for your time.
> I'm a bit undecided whether this
Signed-off-by: Jeremie Courreges-Anglas
---
src/openvpn/misc.c| 4 ++--
src/openvpn/misc.h| 2 +-
src/openvpn/multi.c | 7 ++-
src/openvpn/options.c | 2 +-
4 files changed, 6 insertions(+), 9 deletions(-)
diff --git a/src/openvpn/misc.c b/src/openvpn/misc.c
index 8c7f6116..001fe1c
ACK, test code is good :-) (it passes the tests now, and does not change
anything else). Applying to 2.4 as well, since "test good is good", even
if we might not apply the refactoring bits there.
Your patch has been applied to the master and release/2.4 branch.
commit 2ddb527abe38f5866ff01e91f8
Hi,
On Mon, Jul 17, 2017 at 02:22:55PM +0200, Jan Just Keijser wrote:
> On 17/07/17 14:14, Gert Doering wrote:
> > Hi,
> >
> > On Mon, Jul 17, 2017 at 02:10:11PM +0200, Jan Just Keijser wrote:
> >> this problem is NOT present in OpenVPN 2.3.17; the same warning appears
> >> (route gateway is ambi
On Sun, Nov 5, 2017 at 12:11 PM, Gert Doering wrote:
> Hi,
>
> On Mon, Jul 17, 2017 at 02:22:55PM +0200, Jan Just Keijser wrote:
> > On 17/07/17 14:14, Gert Doering wrote:
> > > Hi,
> > >
> > > On Mon, Jul 17, 2017 at 02:10:11PM +0200, Jan Just Keijser wrote:
> > >> this problem is NOT present in
From: Selva Nair
Currently a route addition using IPAPI or service is skipped if the
route gateway is reachable by multiple interfaces. This changes that
to use the interface with lowest metric.
Reported by Jan Just Keijser
Signed-off-by: Selva Nair
---
src/openvpn/route.c | 3 +--
src/open
Hi,
And the rationale for the patch:
On Mon, Jul 17, 2017 at 8:22 AM, Jan Just Keijser wrote:
> On 17/07/17 14:14, Gert Doering wrote:
>
>> Hi,
>>
>> On Mon, Jul 17, 2017 at 02:10:11PM +0200, Jan Just Keijser wrote:
>>
>>> this problem is NOT present in OpenVPN 2.3.17; the same warning appears
Hi,
On Wed, Oct 11, 2017 at 01:11:26AM +0200, si...@rozman.si wrote:
> From: Simon Rozman
>
> ---
> src/openvpn/block_dns.c | 2 +-
> src/openvpnserv/automatic.c | 2 +-
> src/openvpnserv/common.c | 2 +-
> src/openvpnserv/interactive.c | 4 ++--
> src/openvpnserv/validate.c| 2
Hi,
> > index 7a2d0e3..5422d33 100644
> > --- a/src/openvpnserv/validate.c
> > +++ b/src/openvpnserv/validate.c
> > @@ -298,7 +298,7 @@ IsUserInGroup(PSID sid, const PTOKEN_GROUPS
> token_groups, const WCHAR *group_nam
> > break;
> > }
> > /* If a match is already f
On 05/11/17 20:20, Gert Doering wrote:
>> -modext(LPTSTR dest, int size, LPCTSTR src, LPCTSTR newext)
>> +modext(LPTSTR dest, size_t size, LPCTSTR src, LPCTSTR newext)
>> {
>> int i;
> Not sure why this is needed? The code verifies that size is ">0", so
> a signed variable is ok here.
I wou
Hi,
Let me explain all proposed modifications case-by-case below...
> > diff --git a/src/openvpn/block_dns.c b/src/openvpn/block_dns.c index
> > d43cbcf..f88ba2c 100644
> > --- a/src/openvpn/block_dns.c
> > +++ b/src/openvpn/block_dns.c
> > @@ -370,7 +370,7 @@ get_interface_metric(const NET_IFIND
While openvpn.exe can run multiple concurrent processes, openvpnserv.exe
is usually only one single globally unique running process.
This patch extends openvpnserv.exe to support multiple service instances
in parallel allowing side-by-side OpenVPN installations.
Alternate instances must be instal
From: Selva Nair
Currently a route addition using IPAPI or service is skipped if the
route gateway is reachable by multiple interfaces. This changes that
to use the interface with lowest metric. Implemented by
(i) Do not over-write the return value with TUN_ADAPTER_INDEX_INVALID in
windows
Hi,
I understand the intent here and its nice to get rid of compiler warnings,
when
it makes sense. But be careful while silencing by just a cast.
On Sun, Nov 5, 2017 at 5:06 PM, Simon Rozman wrote:
>
> Hi,
>
> Let me explain all proposed modifications case-by-case below...
>
> > > diff --git a/
> Hi,
>
> returning to this patchset about printing the LZ4 library version...
>
> On Sat, Sep 23, 2017 at 10:52:16AM +0200, Simon Matter wrote:
>> > On Thu, Sep 07, 2017 at 10:40:21PM +0200, Simon Matter wrote:
>> >> While we are at it, I found it useful to see the used LZ4 version at
>> >> runtim
15 matches
Mail list logo
