[Openvpn-devel] Topics for today's community meeting

2013-04-25 Thread Samuli Seppänen
Hi, We're having an IRC meeting today, starting at 18:00 UTC on #openvpn-de...@irc.freenode.net. Current topic list is here: If you have any other things you'd like to bring up, respond to this mail, send me mail privately or add the

Re: [Openvpn-devel] [PATCH 3/5] add ability to send/receive file descriptors via management interface, only used in android so. For now under #ifdef ANDROID

2013-04-25 Thread Gert Doering
Hi, I think the code is fine, but I have some nags about the function names: On Sat, Apr 20, 2013 at 04:22:46PM +0200, Arne Schwabe wrote: > +#ifdef TARGET_ANDROID > +static ssize_t write_fd (int fd, void *ptr, size_t nbytes, int flags, int > sendfd) ... > +static ssize_t read_fd(int fd, void *p

Re: [Openvpn-devel] [PATCH 4/5] Android platform specific changes.

2013-04-25 Thread Gert Doering
Hi, On Sat, Apr 20, 2013 at 04:22:47PM +0200, Arne Schwabe wrote: > index 05c6da2..9fdfd88 100644 > --- a/src/openvpn/options.c > +++ b/src/openvpn/options.c > @@ -1125,7 +1125,9 @@ show_tuntap_options (const struct tuntap_options *o) > } > > #endif > +#endif > > +#if defined(WIN32) || defin

Re: [Openvpn-devel] [PATCH 5/5] Emulate persist-tun on Android

2013-04-25 Thread Gert Doering
Hi, On Sat, Apr 20, 2013 at 04:22:48PM +0200, Arne Schwabe wrote: > On Android changing the configuration of tun is not possible. So instead of > reconfiguring the tun device, open a new tun device and close the old one if > needed I'm not sure I like this patch. Wouldn't it be easier to tackl

Re: [Openvpn-devel] [PATCH 5/5] Emulate persist-tun on Android

2013-04-25 Thread Arne Schwabe
Am 25.04.13 20:58, schrieb Gert Doering: Hi, On Sat, Apr 20, 2013 at 04:22:48PM +0200, Arne Schwabe wrote: On Android changing the configuration of tun is not possible. So instead of reconfiguring the tun device, open a new tun device and close the old one if needed I'm not sure I like this

Re: [Openvpn-devel] [PATCH 4/5] Android platform specific changes.

2013-04-25 Thread Arne Schwabe
Am 25.04.13 20:56, schrieb Gert Doering: Hi, On Sat, Apr 20, 2013 at 04:22:47PM +0200, Arne Schwabe wrote: index 05c6da2..9fdfd88 100644 --- a/src/openvpn/options.c +++ b/src/openvpn/options.c @@ -1125,7 +1125,9 @@ show_tuntap_options (const struct tuntap_options *o) } #endif +#endif