Re: [Openvpn-devel] using openssl feature wherever possible

2021-03-09 Thread Arne Schwabe
Am 09.03.21 um 12:54 schrieb Илья Шипицин: > Hello, > > if nobody minds, I can send several patches that eliminates comparison > of OPENSSL_VERSION, for example > > > diff --git a/src/openvpn/crypto_openssl.c b/src/openvpn/crypto_openssl.c > index 49698e4b..316cca6f 100644 > --- a/src/openvpn/cr

Re: [Openvpn-devel] using openssl feature wherever possible

2021-03-09 Thread David Sommerseth
On 09/03/2021 14:28, Gert Doering wrote: Hi, On Tue, Mar 09, 2021 at 06:26:08PM +0500, ?? wrote: we may keep combo. both #ifdef EVP_PKEY_TLS1_PRF and comment related to supported openssl versions (to drop support if we decide) We could, but we won't. (I can see the benef

Re: [Openvpn-devel] using openssl feature wherever possible

2021-03-09 Thread Gert Doering
Hi, On Tue, Mar 09, 2021 at 06:26:08PM +0500, ?? wrote: > we may keep combo. > both #ifdef EVP_PKEY_TLS1_PRF and comment related to supported openssl > versions (to drop support if we decide) We could, but we won't. (I can see the benefits, but I'm not the one maintaining th

Re: [Openvpn-devel] using openssl feature wherever possible

2021-03-09 Thread Илья Шипицин
we may keep combo. both #ifdef EVP_PKEY_TLS1_PRF and comment related to supported openssl versions (to drop support if we decide) вт, 9 мар. 2021 г. в 17:56, Gert Doering : > Hi, > > On Tue, Mar 09, 2021 at 05:52:12PM +0500, ?? wrote: > > > On Tue, Mar 09, 2021 at 04:54:13PM

Re: [Openvpn-devel] using openssl feature wherever possible

2021-03-09 Thread Gert Doering
Hi, On Tue, Mar 09, 2021 at 05:52:12PM +0500, ?? wrote: > > On Tue, Mar 09, 2021 at 04:54:13PM +0500, ?? wrote: > > > if nobody minds, I can send several patches that eliminates comparison of > > > OPENSSL_VERSION, for example > > > > We do mind. They are

Re: [Openvpn-devel] using openssl feature wherever possible

2021-03-09 Thread Илья Шипицин
вт, 9 мар. 2021 г. в 17:47, Gert Doering : > Hi, > > On Tue, Mar 09, 2021 at 04:54:13PM +0500, ?? wrote: > > if nobody minds, I can send several patches that eliminates comparison of > > OPENSSL_VERSION, for example > > We do mind. They are coded this way on purpose - so when

Re: [Openvpn-devel] using openssl feature wherever possible

2021-03-09 Thread Gert Doering
Hi, On Tue, Mar 09, 2021 at 04:54:13PM +0500, ?? wrote: > if nobody minds, I can send several patches that eliminates comparison of > OPENSSL_VERSION, for example We do mind. They are coded this way on purpose - so when we drop support for OpenSSL before 1.1.0, it is clear f