Re: [Openvpn-devel] Fix for NetBSD with subnet topology

2018-08-09 Thread Adam
>> Here it is, against the current master branch. > > Thanks for re-sending. Unfortunately, it's not complete - it adds > "remote_end", but never initializes it in the TARGET_FREEBSD branch. > > So it sort of works because it happens to puts 0.0.0.0 (or even random > stack data) into "remote_en

Re: [Openvpn-devel] Fix for NetBSD with subnet topology

2018-08-05 Thread Gert Doering
Hi, On Thu, Aug 02, 2018 at 04:26:30PM +0200, Adam wrote: > Here it is, against the current master branch. Thanks for re-sending. Unfortunately, it's not complete - it adds "remote_end", but never initializes it in the TARGET_FREEBSD branch. So it sort of works because it happens to puts 0.0.0.

Re: [Openvpn-devel] Fix for NetBSD with subnet topology

2018-08-02 Thread Adam
> On Wed, Jul 18, 2018 at 04:33:13PM +0200, Adam wrote: >> It turns out, NetBSD needs similar handling of subnet topology for tun >> interfaces as OpenBSD does. >> >> Here is a patch to fix the issue (against OpenVPN 2.4.6): > > So, the patch looks good, and it works nicely on my buildslave. >

Re: [Openvpn-devel] Fix for NetBSD with subnet topology

2018-07-23 Thread Gert Doering
Hi, On Wed, Jul 18, 2018 at 04:33:13PM +0200, Adam wrote: > It turns out, NetBSD needs similar handling of subnet topology for tun > interfaces as OpenBSD does. > > Here is a patch to fix the issue (against OpenVPN 2.4.6): So, the patch looks good, and it works nicely on my buildslave. There's

Re: [Openvpn-devel] Fix for NetBSD with subnet topology

2018-07-23 Thread Gert Doering
Hi, On Mon, Jul 23, 2018 at 04:51:53PM +0200, Adam wrote: > Hoping that clarifies your concern. :) It leaves me a bit puzzled, to be honest... our buildbots *should* have caught it (NetBSD 5.1/amd64 and NetBSD 7.0.1/i386), as it runs a "topology subnet" test and tries to ping the remote IP and

Re: [Openvpn-devel] Fix for NetBSD with subnet topology

2018-07-23 Thread Adam
>> It turns out, NetBSD needs similar handling of subnet topology for tun >> interfaces as OpenBSD does. >> >> Here is a patch to fix the issue (against OpenVPN 2.4.6): > > This comes as a bit of surprise - has something changed here on the > NetBSD side? Which NetBSD version did you test this

Re: [Openvpn-devel] Fix for NetBSD with subnet topology

2018-07-18 Thread Gert Doering
Hi, On Wed, Jul 18, 2018 at 04:33:13PM +0200, Adam wrote: > It turns out, NetBSD needs similar handling of subnet topology for tun > interfaces as OpenBSD does. > > Here is a patch to fix the issue (against OpenVPN 2.4.6): This comes as a bit of surprise - has something changed here on the NetB

Re: [Openvpn-devel] Fix for NetBSD with subnet topology

2018-07-18 Thread Antonio Quartulli
Hello Adam, thanks for your change. could you please submit the patch in proper git format so that it can be easily applied? You can create a patch like that by using the "git format-patch" command after you have commited your changes (you need to clone the git repository for that). After creat