> On Wed, Jul 18, 2018 at 04:33:13PM +0200, Adam wrote: >> It turns out, NetBSD needs similar handling of subnet topology for tun >> interfaces as OpenBSD does. >> >> Here is a patch to fix the issue (against OpenVPN 2.4.6): > > So, the patch looks good, and it works nicely on my buildslave. > > There's two catches here - one is that with this patch format, I do not > get proper git attribution in place, so we really really prefer patches > that come out of "git commit -s ..." -> "git send-email". > > The other catch is that this patch is for 2.4 only, and does not apply > to git master anymore (since Antonio has wrecked tun.c all over :-) ). > > So what I'd really love to see is two patches, one for 2.4 and one for > git master, both coming out of "git commit -s" -> "git send-email" - because > that would speed up the flow tremendously (I can ACK and commit the patches > right away, but if I adapt your patch to "git master", someone else needs > to do the review and the credits who did the fixing are all wrong) > > thanks :) > > gert
Here it is, against the current master branch.
0001-Fix-subnet-topology-on-NetBSD.patch
Description: Binary data
Kind regards, Adam
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel