ect: Re: [Openvpn-devel] [PATCH v14] Add DNS SRV remote host discovery
> support
>
> I have several nitpicks with this patch which I can enumerate later, but
there is at
> least one critical issue which prevents me from ACKing this:
>
> # src/openvpn/openvpn --client --tls-ce
Hi Frank,
> > +"--remote-srv domain [service] : Perform DNS SRV remote host
> discovery.\n"
>
> Missing [proto]
Sure, will add
> > -if (!proto_is_udp(ce->proto) && options->mtu_test)
> > +/* Defer validation for --remote-srv with auto protocol */
> > +if (!proto_is_udp(ce->proto
Smaller nitpicks:
On Wed, Nov 30, 2022 at 09:57:18PM +0100, Gert Doering wrote:
> From: Vladislav Grishenko
[...]
> diff --git a/src/openvpn/init.c b/src/openvpn/init.c
> index c2154b8d..3a70748e 100644
> --- a/src/openvpn/init.c
> +++ b/src/openvpn/init.c
> @@ -350,7 +350,12 @@ management_callba
I have several nitpicks with this patch which I can enumerate later, but there
is at least one critical issue which prevents me from ACKing this:
# src/openvpn/openvpn --client --tls-cert-profile insecure --ca ../ca.crt
--cert ../t_client.c\
rt --key ../t_client.key--remote-cert-tls ser
