Hi Frank,
> > + "--remote-srv domain [service] : Perform DNS SRV remote host
> discovery.\n"
>
> Missing [proto]
Sure, will add
> > - if (!proto_is_udp(ce->proto) && options->mtu_test)
> > + /* Defer validation for --remote-srv with auto protocol */
> > + if (!proto_is_udp(ce->proto) && options->mtu_test
> > + && !(ce->remote_srv && ce->proto == PROTO_AUTO))
> > {
> > msg(M_USAGE, "--mtu-test only makes sense with --proto udp");
>
> You disable this test here, but you don't add this in any of the
> later checks. So it seems this test is just completely removed when
> using remote-srv?
Right, this check should be moved into options_postprocess_verify_ce_proto()
and seems forgotten, will add it too. Thank you
> > + * get_cached_srv_entry return 0 on success and -1
>
> "returns"
Ok, sure
--
Best Regards, Vladislav Grishenko
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
