Re: [Openvpn-devel] [PATCH 3/3] uncrustify openvpn/ sources

2018-12-12 Thread Gert Doering
Hi, On Wed, Dec 12, 2018 at 11:50:20PM +0100, David Sommerseth wrote: > I do see my uncrustify run have some weird disagreements in > src/openvpn/push.c, where it wants to indent all the switch case parts one > more level. Not sure why this didn't hit Gerts run though, this change does > seem app

Re: [Openvpn-devel] [PATCH 3/3] uncrustify openvpn/ sources

2018-12-12 Thread David Sommerseth
On 12/12/2018 12:33, Antonio Quartulli wrote: > I know we want to get "uncrustity-clean", but maybe we can tweak some > options to comply with my remarks above? if not...well...uncrustify will > decide for our codestyle ;P Now I spotted your feedbacks, way too late :( Sorry about that! As I walk

Re: [Openvpn-devel] [PATCH 3/3] uncrustify openvpn/ sources

2018-12-12 Thread Antonio Quartulli
Hi, On 30/11/2018 23:56, Gert Doering wrote: [cut] > diff --git a/src/openvpn/cryptoapi.c b/src/openvpn/cryptoapi.c > index fa057cb2..9687d8c2 100644 > --- a/src/openvpn/cryptoapi.c > +++ b/src/openvpn/cryptoapi.c > @@ -159,7 +159,8 @@ ms_error_text(DWORD ms_err) > /* trim to the left *