On 12/12/2018 12:33, Antonio Quartulli wrote: > I know we want to get "uncrustity-clean", but maybe we can tweak some > options to comply with my remarks above? if not...well...uncrustify will > decide for our codestyle ;P
Now I spotted your feedbacks, way too late :( Sorry about that! As I walked through this file, I thought this is better keeping it out-of-the-loop for a few more weeks. The code now is mostly compatible with the _current_ uncrustify.conf available in the ./dev-tools, which is a good step forward from the current state. And I considered the current result acceptable for now. I do see my uncrustify run have some weird disagreements in src/openvpn/push.c, where it wants to indent all the switch case parts one more level. Not sure why this didn't hit Gerts run though, this change does seem appropriate to our CodeStyle wiki page. My uncrustify also disagrees in src/openvpn/buffer.c:474, where gc_addspecial(...) gets the space between 'void' and '(free_function)' removed. Otherwise there is nothing unexpected (including the change in src/openvpn/ssl.c already mentioned in the "PATCH applied" mail). But this can all be related to uncrustify versions and bugs there. I'll try to get a newer version built and see what happens then. But I think we just need to accept that we can only push uncrustify to some degree towards our desired coding style and then to accept the minor gaps to our view of full perfection. Telling contributors to "run your changes through uncrustify before sending patches" will definitely help. -- kind regards, David Sommerseth OpenVPN Inc
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
