Re: [Openvpn-devel] [PATCH 04/28] Add documentation for swap_hmac function

2022-04-24 Thread Gert Doering
Hi, On Fri, Apr 22, 2022 at 09:05:34PM +0200, Gert Doering wrote: > I was about to merge this as "it is easy, and does not change code", but > if we add documentation, it should be correct :-) - and this schematic > does not match my understanding of the actual code - which seems to > swap > >

Re: [Openvpn-devel] [PATCH 04/28] Add documentation for swap_hmac function

2022-04-22 Thread Gert Doering
Hi, On Fri, Apr 22, 2022 at 03:40:33PM +0200, Arne Schwabe wrote: > +/** > + * Move a packet authentication HMAC + related fields to or from the front > + * of the buffer so it can be processed by encrypt/decrypt. > + * > + * Turning the on wire format that starts with the opcode to a format > + *