Re: [Openvpn-devel] [PATCH] Uniform snwprintf() across MinGW and MSVC compilers

On 16/10/2017 20:34, Илья Шипицин wrote: > > > 2017-10-16 20:33 GMT+05:00 Selva >: > > > Hi  > > On Mon, Oct 16, 2017 at 4:22 AM, Илья Шипицин > wrote: > > > > 2017-10-16 13:05 GMT+05:00 Samuli Seppänen

Re: [Openvpn-devel] [PATCH] Uniform snwprintf() across MinGW and MSVC compilers

2017-10-16 23:17 GMT+05:00 Selva : > Hi, > > On Mon, Oct 16, 2017 at 12:57 PM, Gert Doering > wrote: > >> Hi, >> >> On Mon, Oct 16, 2017 at 11:33:02AM -0400, Selva wrote: >> > I did a quick test on ubuntu trusty (14.04.05 LTS), and as you pointed >> > out, it fails while >> > compiling block_dns

Re: [Openvpn-devel] [PATCH] Uniform snwprintf() across MinGW and MSVC compilers

Hi, On Mon, Oct 16, 2017 at 12:57 PM, Gert Doering wrote: > Hi, > > On Mon, Oct 16, 2017 at 11:33:02AM -0400, Selva wrote: > > I did a quick test on ubuntu trusty (14.04.05 LTS), and as you pointed > > out, it fails while > > compiling block_dns.c because of some errors in the headers for the >

Re: [Openvpn-devel] [PATCH] Uniform snwprintf() across MinGW and MSVC compilers

2017-10-16 20:33 GMT+05:00 Selva : > > Hi > > On Mon, Oct 16, 2017 at 4:22 AM, Илья Шипицин > wrote: > >> >> >> 2017-10-16 13:05 GMT+05:00 Samuli Seppänen : >> >>> On 13/10/2017 20:48, Selva wrote: >>> >>> > @samuli: Which versions of mingw-w64 should we test against to ensure >>> > release and s

Re: [Openvpn-devel] [PATCH] Uniform snwprintf() across MinGW and MSVC compilers

Hi, On Mon, Oct 16, 2017 at 11:33:02AM -0400, Selva wrote: > I did a quick test on ubuntu trusty (14.04.05 LTS), and as you pointed > out, it fails while > compiling block_dns.c because of some errors in the headers for the > windows filtering platform API. All the bits are there so its possible

Re: [Openvpn-devel] [PATCH] Uniform snwprintf() across MinGW and MSVC compilers

Hi On Mon, Oct 16, 2017 at 4:22 AM, Илья Шипицин wrote: > > > 2017-10-16 13:05 GMT+05:00 Samuli Seppänen : > >> On 13/10/2017 20:48, Selva wrote: >> >> > @samuli: Which versions of mingw-w64 should we test against to ensure >> > release and snapshot builds would succeed? >> >> Right now _we_ use

Re: [Openvpn-devel] [PATCH] Uniform snwprintf() across MinGW and MSVC compilers

Hi, On Mon, Oct 16, 2017 at 4:05 AM, Samuli Seppänen wrote: > On 13/10/2017 20:48, Selva wrote: > > > @samuli: Which versions of mingw-w64 should we test against to ensure > > release and snapshot builds would succeed? > > Right now _we_ use Ubuntu 16.04 for building: > > mingw-w64 4.0.4 > g

Re: [Openvpn-devel] [PATCH] Uniform snwprintf() across MinGW and MSVC compilers

2017-10-16 13:05 GMT+05:00 Samuli Seppänen : > On 13/10/2017 20:48, Selva wrote: > > Hi, > > > > On Fri, Oct 13, 2017 at 12:55 AM, Simon Rozman > > wrote: > > ... > > > > > > > As said above, I would have replaced all _snwprintf and snwprintf > by > > > swprintf >

Re: [Openvpn-devel] [PATCH] Uniform snwprintf() across MinGW and MSVC compilers

On 13/10/2017 20:48, Selva wrote: > Hi, > > On Fri, Oct 13, 2017 at 12:55 AM, Simon Rozman > wrote: > ... > > > > As said above, I would have replaced all _snwprintf and snwprintf by > > swprintf > > and avoided the #define. That has the added advantage that

Re: [Openvpn-devel] [PATCH] Uniform snwprintf() across MinGW and MSVC compilers

Hi, On Fri, Oct 13, 2017 at 12:55 AM, Simon Rozman wrote: ... > > > As said above, I would have replaced all _snwprintf and snwprintf by > > swprintf > > and avoided the #define. That has the added advantage that mingw builds > > also will no longer depend on the non-standard snwprintf. > > Are

Re: [Openvpn-devel] [PATCH] Uniform snwprintf() across MinGW and MSVC compilers

Hi, > For book keeping its easier if version 2 of a patch is sent to the same > thread > as the original (e.g., use --in-reply-to: in git send-email) and > [PATCH > v2 01/13] in header. Thank you, I'll learn the team-play. Please have patience with me. :) > > On Thu, Oct 12, 2017 at 3:24 AM,

Re: [Openvpn-devel] [PATCH] Uniform snwprintf() across MinGW and MSVC compilers

Hi, For book keeping its easier if version 2 of a patch is sent to the same thread as the original (e.g., use --in-reply-to: in git send-email) and [PATCH v2 01/13] in header. Anyway, this one is v2 of [PATCH 01/13] https://www.mail-archive.com/openvpn-devel@lists.sourceforge .net/msg15583.html

Re: [Openvpn-devel] [PATCH] Uniform snwprintf() across MinGW and MSVC compilers

Hi Simon, On 12/10/17 16:09, Simon Rozman wrote: > This is a follow-up (or better worded: a replacement) patch for "[PATCH > 01/13] snwprintf() => _snwprintf()". > > I have taken into consideration all Selva's recommendations. > In case you weren't, you can write comments like the one above rig

Re: [Openvpn-devel] [PATCH] Uniform snwprintf() across MinGW and MSVC compilers

This is a follow-up (or better worded: a replacement) patch for "[PATCH 01/13] snwprintf() => _snwprintf()". I have taken into consideration all Selva's recommendations. Best regards, Simon > -Original Message- > From: Simon Rozman [mailto:si...@rozman.si] > Sent: Thursday, October 12, 2