Re: [Openvpn-devel] [PATCH] Fix CN maximum length

2015-03-05 Thread Steffan Karger
On 05-02-15 23:08, Gert Doering wrote: On Thu, Feb 05, 2015 at 06:15:21PM -0300, Jorge Luiz Silva Peixoto wrote: 64 characters according to some specs, but needs to be 65 to allow NULL termination? I'm speculating here ... so if I'm right I'd appreciate an update to the comment above if it incl

Re: [Openvpn-devel] [PATCH] Fix CN maximum length

2015-02-05 Thread Gert Doering
Hi On Thu, Feb 05, 2015 at 06:15:21PM -0300, Jorge Luiz Silva Peixoto wrote: > > 64 characters according to some specs, but needs to be 65 to allow NULL > > termination? I'm speculating here ... so if I'm right I'd appreciate an > > update to the comment above if it includes NULL termination or n

Re: [Openvpn-devel] [PATCH] Fix CN maximum length

2015-02-05 Thread Jorge Luiz Silva Peixoto
2015-02-05 7:49 GMT-03:00 David Sommerseth : > On 04/02/15 18:01, Jorge Luiz Silva Peixoto wrote: >> The following patch fixes CN maximum length as discussed with Steffan >> Kargen at openvpn users mailing list. >> >> >> Signed-off-by: Jorge Peixoto >> --- >> src/openvpn/ssl_verify.c | 6 +++--- >

Re: [Openvpn-devel] [PATCH] Fix CN maximum length

2015-02-05 Thread Gert Doering
Hi, On Wed, Feb 04, 2015 at 02:01:58PM -0300, Jorge Luiz Silva Peixoto wrote: > subject, > -TLS_USERNAME_LEN); > +TLS_USERNAME_LEN-1); As David has remarked, this is not really easy to understand - better keep this at 64, and ensure the buffers whe

Re: [Openvpn-devel] [PATCH] Fix CN maximum length

2015-02-05 Thread David Sommerseth
On 04/02/15 18:01, Jorge Luiz Silva Peixoto wrote: > The following patch fixes CN maximum length as discussed with Steffan > Kargen at openvpn users mailing list. > > > Signed-off-by: Jorge Peixoto > --- > src/openvpn/ssl_verify.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >