Hi On Thu, Feb 05, 2015 at 06:15:21PM -0300, Jorge Luiz Silva Peixoto wrote: > > 64 characters according to some specs, but needs to be 65 to allow NULL > > termination? I'm speculating here ... so if I'm right I'd appreciate an > > update to the comment above if it includes NULL termination or not. > > OK. Do I send this patch again to the list? Comment updated below.
Yes, please. (Please mark as "patch v2"). > /** Maximum length of common name (rfc5280) + null character byte */ > -#define TLS_USERNAME_LEN 64 > +#define TLS_USERNAME_LEN 65 NAK on this approach, see my other mail. If this is the length, it should be the length - and if we need extra space in the buffer, the buffer should have the "+1", and not all the other stuff that want the real length a "-1". gert -- USENET is *not* the non-clickable part of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany g...@greenie.muc.de fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
pgp1oeQUwdYls.pgp
Description: PGP signature