Re: [Openvpn-devel] [PATCH] Bogus check for negative values on an unsigned number.

2012-02-28 Thread Gert Doering
Hi, On Fri, Feb 17, 2012 at 10:58:16PM +0100, Gert Doering wrote: > [ on ir->netbits and ir6->netbits, signed int vs. unsigned int ] > > Thanks for reporting this. I'll look into it. I've dug a bit further into the code, and the IPv4 and IPv6 code differ here - IPv4 flags "a host iroute" with i

Re: [Openvpn-devel] [PATCH] Bogus check for negative values on an unsigned number.

2012-02-18 Thread Frank de Brabander
I totally agree on not ACKing the patch and your solution description ;-) I tried to start a discussion on IRC about the preferred solution before sending this patch, but that didn't get very far. Op 17 februari 2012 22:58 heeft Gert Doering het volgende geschreven: > Hi, > > On Fri, Feb 17, 2012

Re: [Openvpn-devel] [PATCH] Bogus check for negative values on an unsigned number.

2012-02-17 Thread Gert Doering
Hi, On Fri, Feb 17, 2012 at 10:04:50PM +0100, Frank de Brabander wrote: > This causes compiler warnings when using Clang instead of default GCC. I'm not particularily interested in source code fixes "just to silence a compiler warning" - but Clang is right, of course, that this variable cannot ev