I totally agree on not ACKing the patch and your solution description ;-) I tried to start a discussion on IRC about the preferred solution before sending this patch, but that didn't get very far.
Op 17 februari 2012 22:58 heeft Gert Doering <g...@greenie.muc.de> het volgende geschreven: > Hi, > > On Fri, Feb 17, 2012 at 10:04:50PM +0100, Frank de Brabander wrote: >> This causes compiler warnings when using Clang instead of default GCC. > > I'm not particularily interested in source code fixes "just to silence > a compiler warning" - but Clang is right, of course, that this variable > cannot ever be negative, and thus it should be cleaned up :-) > > I'm not ACKing this patch anyway, because I think the issue is bigger - I > want to look at the IPv4 code paths and see whether the IPv4 "netbits" > structure element can ever be negative - and if yes, figure out whether > this should be possible for IPv6, and if not, convert the IPv4 netbits > to "unsigned int" as well, and get rid of the if() statement there as > well. > > Thanks for reporting this. I'll look into it. > > gert > > -- > USENET is *not* the non-clickable part of WWW! > //www.muc.de/~gert/ > Gert Doering - Munich, Germany g...@greenie.muc.de > fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
