Re: [Openvpn-devel] openvpn with udp lost event.

2019-06-06 Thread wei wang
On Tue, Apr 23, 2019 at 7:30 PM Arne Schwabe wrote: > > Am 23.04.19 um 05:01 schrieb wei wang: > > 3. clean client connect defered ret file when close instance. > > > > I agree that I missed a place in which I should cleaning up the temp > file but adding it to close_instance seem more like a work

Re: [Openvpn-devel] openvpn with udp lost event.

2019-04-23 Thread wei wang
On Tue, Apr 23, 2019 at 7:30 PM Arne Schwabe wrote: > I agree that I missed a place in which I should cleaning up the temp > file but adding it to close_instance seem more like a workaround than a > real solution. Again describing more context would be nice here. What > exactly is this trying to

Re: [Openvpn-devel] openvpn with udp lost event.

2019-04-23 Thread Arne Schwabe
Am 23.04.19 um 05:01 schrieb wei wang: > 3. clean client connect defered ret file when close instance. > I agree that I missed a place in which I should cleaning up the temp file but adding it to close_instance seem more like a workaround than a real solution. Again describing more context would b

Re: [Openvpn-devel] openvpn with udp lost event.

2019-04-23 Thread Arne Schwabe
Am 22.04.19 um 11:34 schrieb wei wang: > And I have another question about multi_process_io_udp lost event. > Is there some problem if we change if{} else if{} to if {} if {}. > e.g.: > To be honest that code is very complicated and without a in deep review of what all the stuff is doing, it is h

Re: [Openvpn-devel] openvpn with udp lost event.

2019-04-23 Thread Arne Schwabe
Am 22.04.19 um 11:26 schrieb wei wang: > 1. When client-connect tests whether the user has written the > configuration, we should check to see if the file size is 0, not > whether the file exists. I am sorry but you need to provide a bit more context to point out why you think that change is right

Re: [Openvpn-devel] openvpn with udp lost event.

2019-04-22 Thread wei wang
3. clean client connect defered ret file when close instance. diff --git a/src/openvpn/multi.c b/src/openvpn/multi.c index 27c6e935..7291d651 100644 --- a/src/openvpn/multi.c +++ b/src/openvpn/multi.c @@ -685,6 +685,9 @@ multi_close_instance(struct multi_context *m, set_cc_config(mi, NULL);

Re: [Openvpn-devel] openvpn with udp lost event.

2019-04-22 Thread wei wang
And I have another question about multi_process_io_udp lost event. Is there some problem if we change if{} else if{} to if {} if {}. e.g.: diff --git a/src/openvpn/mudp.c b/src/openvpn/mudp.c index a604d217..18dc009d 100644 --- a/src/openvpn/mudp.c +++ b/src/openvpn/mudp.c @@ -220,12 +220,12 @@ m

Re: [Openvpn-devel] openvpn with udp lost event.

2019-04-22 Thread wei wang
1. When client-connect tests whether the user has written the configuration, we should check to see if the file size is 0, not whether the file exists. Because the configuration file is created by openvpn itself. 2. multi_client_connect_early_setup should be called for the first time. diff --g

Re: [Openvpn-devel] openvpn with udp lost event.

2019-04-21 Thread Arne Schwabe
Am 20.04.2019 um 10:37 schrieb wei wang: > Thanks for your guys reply. > > The correct thing is that synchronous authentication increases the > probability of event loss. > But deferred auth is not what we need, we need deferred client-connect > actually. > I have found that the patch set > "https

Re: [Openvpn-devel] openvpn with udp lost event.

2019-04-20 Thread Gert Doering
Hi, On Sat, Apr 20, 2019 at 04:37:03PM +0800, wei wang wrote: > I have found that the patch set > "https://patchwork.openvpn.net/project/openvpn2/list/?series=413"; has > implement it. > But it has not been updated for several months. Is there someone still > work on it? We test with it for clien

Re: [Openvpn-devel] openvpn with udp lost event.

2019-04-20 Thread wei wang
Thanks for your guys reply. The correct thing is that synchronous authentication increases the probability of event loss. But deferred auth is not what we need, we need deferred client-connect actually. I have found that the patch set "https://patchwork.openvpn.net/project/openvpn2/list/?series=41

Re: [Openvpn-devel] openvpn with udp lost event.

2019-04-17 Thread Илья Шипицин
ср, 17 апр. 2019 г. в 15:19, Jan Just Keijser : > On 15/04/19 14:29, wei wang wrote: > > Hi, > > > > For function multi_process_io_udp receive many events, but only > > process one at a time. Doest it cause the event to be lost? > yes it does > > In our test, we had create thousands of client. Whe

Re: [Openvpn-devel] openvpn with udp lost event.

2019-04-17 Thread Jan Just Keijser
On 15/04/19 14:29, wei wang wrote: Hi, For function multi_process_io_udp receive many events, but only process one at a time. Doest it cause the event to be lost? yes it does In our test, we had create thousands of client. When clients connect to server at a time, for the clients which already

[Openvpn-devel] openvpn with udp lost event.

2019-04-15 Thread wei wang
Hi, For function multi_process_io_udp receive many events, but only process one at a time. Doest it cause the event to be lost? In our test, we had create thousands of client. When clients connect to server at a time, for the clients which already connected on this server will not receive packet