Am 22.04.19 um 11:26 schrieb wei wang: > 1. When client-connect tests whether the user has written the > configuration, we should check to see if the file size is 0, not > whether the file exists.
I am sorry but you need to provide a bit more context to point out why you think that change is right. In non defferred we wait for the script to exit and in deferred we check the return status of an extra file before reading in the client connect file, so I don't get we this change is required. > Because the configuration file is created by openvpn itself. > 2. multi_client_connect_early_setup should be called for the first time. > Again, I don't get your line of argument why we should NOT call this function if coming from a deferred code path. That seems to be a change in the wrong direction. So an explaination of the problem you are seeing and what this is trying to fix would be appreciated. > diff --git a/src/openvpn/multi.c b/src/openvpn/multi.c > index 697994b8..27c6e935 100644 > It is unclear on what you are referring here to: git branch --contains 697994b8 error: object 697994b8acd6094aa585c711855b970e1c2bd1c3 is a blob, not a commit error: no such commit 697994b8 It looks from the code like my deferred client connect patch set. In future please include a reference what this is based one. Arne
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
