Re: [Openvpn-devel] coverity issue 1 - MF_EXTERNAL_KEY

2012-12-16 Thread Gert Doering
Hi, On Fri, Dec 14, 2012 at 07:14:27PM +0100, Gert Doering wrote: > Issue #1: "logical dead code", in options.c, line 2277: This has already been fixed, I just hit the gap between "fix, ack, forget", "coverity checks" and "david pushes the fix". commit feca0900dd005777 -> issue solved. Easy.

Re: [Openvpn-devel] coverity issue 1 - MF_EXTERNAL_KEY

2012-12-14 Thread Gert Doering
Hi, On Fri, Dec 14, 2012 at 07:14:27PM +0100, Gert Doering wrote: > coverity scanned our source tree, found 201 false positives (they do not > like msg(M_ERR, ...), msg(M_WARN, ...) or msg(M_FATAL, ...)), and 3 > actual code confusions. Small correction: in the most recent run, they only found 20

[Openvpn-devel] coverity issue 1 - MF_EXTERNAL_KEY

2012-12-14 Thread Gert Doering
Hi, coverity scanned our source tree, found 201 false positives (they do not like msg(M_ERR, ...), msg(M_WARN, ...) or msg(M_FATAL, ...)), and 3 actual code confusions. I'm now going to post them here, to elicit comments on whether we want to fix 'em, just ignore 'em, or throw out all the source