Hi, coverity scanned our source tree, found 201 false positives (they do not like msg(M_ERR, ...), msg(M_WARN, ...) or msg(M_FATAL, ...)), and 3 actual code confusions.
I'm now going to post them here, to elicit comments on whether we want
to fix 'em, just ignore 'em, or throw out all the source and go drink
a beer.
Issue #1: "logical dead code", in options.c, line 2277:
else
{
notnull (options->cert_file, "certificate file (--cert) or
PKCS#12 file (--pkcs12)");
#ifdef MANAGMENT_EXTERNAL_KEY
if (!options->management_flags & MF_EXTERNAL_KEY)
#endif
notnull (options->priv_key_file, "private key file (--key) or
PKCS#12 file (--pkcs12)");
}
... if I read this right, this is "operator precedence again", and there
need to be brackets
#ifdef MANAGMENT_EXTERNAL_KEY
if (! (options->management_flags & MF_EXTERNAL_KEY) )
#endif
... Arne?
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
pgpAFTOXE8Pgh.pgp
Description: PGP signature
