Re: [Openvpn-devel] OVPN patching process RE: [PATCH] Fix non-C89 comments

2009-02-02 Thread James Yonan
David, A couple issues with the patch: * sscanf usage doesn't check for buffer overflow. * You use gw_if_name in some places and gw_ifname in other places. To eliminate confusion it would be best to use a consistent form. Also, to reiterate, try submitting the patch as an attachment to deal

Re: [Openvpn-devel] OVPN patching process RE: [PATCH] Fix non-C89 comments

2009-01-29 Thread Alon Bar-Lev
On 1/29/09, David Balazic wrote: > Hi! > > I sent a patch recently to the openvpn-devel list and got > no reply whatsoever. Did I miss something ? Is there a procedure > that I did not follow ? Send the patch again. At the subject specify [PATCH] Place the patch inline, be sure your mail clien

Re: [Openvpn-devel] OVPN patching process RE: [PATCH] Fix non-C89 comments

2009-01-29 Thread Thomas NOEL
David Sommerseth a écrit : > From what I've heard from other sources as well, this is usually the > normal procedure ... pop the patch to this mailing list and watch > if something happens ... or not you might get a response, and you > might not. Who knows ... It is a good summary of t

Re: [Openvpn-devel] OVPN patching process RE: [PATCH] Fix non-C89 comments

2009-01-29 Thread David Sommerseth
David Balazic wrote: Hi! I sent a patch recently to the openvpn-devel list and got no reply whatsoever. Did I miss something ? Is there a procedure that I did not follow ? From what I've heard from other sources as well, this is usually the normal procedure ... pop the patch to this mailing

[Openvpn-devel] OVPN patching process RE: [PATCH] Fix non-C89 comments

2009-01-29 Thread David Balazic
Hi! I sent a patch recently to the openvpn-devel list and got no reply whatsoever. Did I miss something ? Is there a procedure that I did not follow ? That patch is to fix a longstanding bug that users encountered. Regards, David PS: the mail message in question is : Fix for "Cannot read curren