David,
A couple issues with the patch:
* sscanf usage doesn't check for buffer overflow.
* You use gw_if_name in some places and gw_ifname in other places. To
eliminate confusion it would be best to use a consistent form.
Also, to reiterate, try submitting the patch as an attachment to deal
with email client munging issues.
Thanks,
James
David Balazic wrote:
Hi!
I sent a patch recently to the openvpn-devel list and got
no reply whatsoever. Did I miss something ? Is there a procedure
that I did not follow ?
That patch is to fix a longstanding bug that users encountered.
Regards,
David
PS: the mail message in question is :
Fix for "Cannot read current default gateway" problem on Linux
http://article.gmane.org/gmane.network.openvpn.devel/2472
-----Original Message-----
From: Alon Bar-Lev [mailto:alon.bar...@gmail.com]
Sent: Tuesday, January 27, 2009 5:32 PM
To: openvpn-devel@lists.sourceforge.net
Subject: Re: [Openvpn-devel] [PATCH] Fix non-C89 comments
Sent this to James.
Did not apply.
My queue is at:
http://svn.openvpn.net/projects/openvpn/contrib/alon
On 1/27/09, Matthias Andree
<ma+ov...@dt.e-technik.uni-dortmund.de> wrote:
Hi,
openvpn uses non-C89 //-style comments in two places.
Patch to convert
these to /* ... */ style comments attached.
Best
--
Matthias Andree
--------------------------------------------------------------
----------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
--------------------------------------------------------------
----------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
