Re: [Openvpn-devel] NTLMv2 patch corrected

2008-05-09 Thread Mirek Zajic
Sending the patch as an attachment. Miroslav Zajic NextSoft s.r.o. James Yonan napsal(a): Mirek Zajic wrote: I'm sending NTLMv2 patch again. I hope that everything is correct now :-) Again thanks to Alon for his feedback. Miroslav Zajic NextSoft s.r.o. P.S. I moved int64 macros to ntlm.c.

Re: [Openvpn-devel] NTLMv2 patch corrected

2008-05-08 Thread James Yonan
Mirek Zajic wrote: I'm sending NTLMv2 patch again. I hope that everything is correct now :-) Again thanks to Alon for his feedback. Miroslav Zajic NextSoft s.r.o. P.S. I moved int64 macros to ntlm.c. I left them unchanged, becouse they could be useful in future. Mirek, can you send t

Re: [Openvpn-devel] NTLMv2 patch corrected

2008-03-13 Thread Mirek Zajic
I'm sending NTLMv2 patch again. I hope that everything is correct now :-) Again thanks to Alon for his feedback. Miroslav Zajic NextSoft s.r.o. P.S. I moved int64 macros to ntlm.c. I left them unchanged, becouse they could be useful in future. diff -Naur openvpn-2.1/ntlm.c openvpn-NTLMv2-p

Re: [Openvpn-devel] NTLMv2 patch corrected

2008-03-13 Thread Alon Bar-Lev
On 3/12/08, Mirek Zajic wrote: > > Just noticed that openvpn has: openvpn_gettimeofday() which works also > > for WIN32... Maybe use this one? > > > > > > openvpn_time works fine, why to change? I remember you used gettimeofday in previous versions... I missed the openvpn_gettimeofday() avail

Re: [Openvpn-devel] NTLMv2 patch corrected

2008-03-12 Thread Mirek Zajic
Thans for your comments. There are some things that have to be explained before I'll make the changes, please read bellow. Alon Bar-Lev napsal(a): On 3/12/08, Mirek Zajic wrote: Hello, I have finally made some changes to the NTLMv2 patch according to Alon's comments. Now it should also b

Re: [Openvpn-devel] NTLMv2 patch corrected

2008-03-12 Thread Alon Bar-Lev
On 3/12/08, Mirek Zajic wrote: > Hello, > I have finally made some changes to the NTLMv2 patch according to Alon's > comments. Now it should also be architecture independent. > > Miroslav Zajic > NextSoft s.r.o. Hi! Great! Some more comments... :) > +timestamp_ull = openvpn_time(NULL);

Re: [Openvpn-devel] NTLMv2 patch corrected

2008-03-12 Thread Mirek Zajic
Hello, I have finally made some changes to the NTLMv2 patch according to Alon's comments. Now it should also be architecture independent. Miroslav Zajic NextSoft s.r.o. diff -Naur openvpn-2.1/ntlm.c openvpn-NTLMv2-predelane-2.1/ntlm.c --- openvpn-2.1/ntlm.c2008-01-13 21:25:52.915264000

Re: [Openvpn-devel] NTLMv2 patch corrected

2008-01-15 Thread Mirek Zajic
The keep-alive is enabled only when ntlm or ntlm2 is used. The reason is that proxy may close the connection before ntlm messages are sent. It is the correct way to always use keep-alive when ntlm is used. I'm going to fix the architecture independency and other things and I'll send the patch

Re: [Openvpn-devel] NTLMv2 patch corrected

2008-01-15 Thread Alon Bar-Lev
On 1/15/08, Mirek Zajic wrote: > Thank you for info. I wanted to use equal indentation rules in the whole > file. I'm sending another patch without these indentation changes. > > Also, this code was originally written for x86 processors with 32-bit > environment. Different wordsize or endian may c

Re: [Openvpn-devel] NTLMv2 patch corrected

2008-01-15 Thread Mirek Zajic
Thank you for info. I wanted to use equal indentation rules in the whole file. I'm sending another patch without these indentation changes. Also, this code was originally written for x86 processors with 32-bit environment. Different wordsize or endian may cause trouble when porting to other pl

Re: [Openvpn-devel] NTLMv2 patch corrected

2008-01-15 Thread Alon Bar-Lev
Please also don't keep changing the subject... Just reply to the same thread. On 1/15/08, Alon Bar-Lev wrote: > On 1/15/08, Mirek Zajic wrote: > > I'm sending the patch again. Now it should be correctly diffed against > > version 2.1. > > Great! > > But you have change the indentation, so your c

Re: [Openvpn-devel] NTLMv2 patch corrected

2008-01-15 Thread Alon Bar-Lev
On 1/15/08, Mirek Zajic wrote: > I'm sending the patch again. Now it should be correctly diffed against > version 2.1. Great! But you have change the indentation, so your changes cannot be reviewed. For example, the first function create_des_keys, you did not modify it, but still it modified. P

[Openvpn-devel] NTLMv2 patch corrected

2008-01-15 Thread Mirek Zajic
I'm sending the patch again. Now it should be correctly diffed against version 2.1. Configuration is done with standard http-proxy command in config file, with 'ntlm2' setting for auth method, for. ex.: http-proxy 192.168.0.1 8080 stdin ntlm2 Username to proxy can be passed among with auth. d

Re: [Openvpn-devel] NTLMv2 patch

2008-01-13 Thread Alon Bar-Lev
On 1/13/08, Mirek Zajic wrote: > I'm sending the patch for NTLMv2 proxy authorization support. Please > note that I diffed against version 2.0.9 because it was the version that > I modified. Hope that it's not too confusing. It is. Please rebase to latest svn. svn checkout http://svn.openvpn.net

[Openvpn-devel] NTLMv2 patch

2008-01-13 Thread Mirek Zajic
I'm sending the patch for NTLMv2 proxy authorization support. Please note that I diffed against version 2.0.9 because it was the version that I modified. Hope that it's not too confusing. The features are: -NTLMv2 support -Allows user to specify authorization domain in username (both DOMAIN\us