Re: [Openvpn-devel] [PATCH applied] Re: wintun: add --windows-driver config option

2019-11-12 Thread David Sommerseth
On 12/11/2019 19:39, David Sommerseth wrote: > On 09/11/2019 16:00, Gert Doering wrote: >> Hi, >> >> On Sat, Nov 09, 2019 at 03:49:51PM +0100, Gert Doering wrote: >>> wintun: add --windows-driver config option >>> >>> Signed-off-by: Lev Stipakov >>> Acked-by: Simon Rozman >> >> Ooo

Re: [Openvpn-devel] [PATCH applied] Re: wintun: add --windows-driver config option

2019-11-12 Thread David Sommerseth
On 09/11/2019 16:00, Gert Doering wrote: > Hi, > > On Sat, Nov 09, 2019 at 03:49:51PM +0100, Gert Doering wrote: >> wintun: add --windows-driver config option >> >> Signed-off-by: Lev Stipakov >> Acked-by: Simon Rozman > > Ooops. Misattributed the ACK, so this was really Steffan

Re: [Openvpn-devel] [PATCH applied] Re: wintun: add --windows-driver config option

2019-11-09 Thread Gert Doering
Hi, On Sat, Nov 09, 2019 at 03:49:51PM +0100, Gert Doering wrote: > wintun: add --windows-driver config option > > Signed-off-by: Lev Stipakov > Acked-by: Simon Rozman Ooops. Misattributed the ACK, so this was really Steffan's ACK. I am not amending & re-pusing the commit. Th

[Openvpn-devel] [PATCH applied] Re: wintun: add --windows-driver config option

2019-11-09 Thread Gert Doering
Your patch has been applied to the master branch. (It needed a bit of manual massaging as the context in options.c:851 changed due to the merge of the VLAN patches) I'm not totally happy with introducing a new function (parse_windows_driver()) to effectively map two constant strings to a boolan v