On 09/11/2019 16:00, Gert Doering wrote: > Hi, > > On Sat, Nov 09, 2019 at 03:49:51PM +0100, Gert Doering wrote: >> wintun: add --windows-driver config option >> >> Signed-off-by: Lev Stipakov <l...@openvpn.net> >> Acked-by: Simon Rozman <si...@rozman.si> > > Ooops. Misattributed the ACK, so this was really Steffan's ACK. > > I am not amending & re-pusing the commit. This will call more confusion. > > Sorry.
Wise choice. However you can use another little git feature ... git notes <https://web.archive.org/web/20180121193320/http://git-scm.com/blog/2010/08/25/notes.html> <https://git-scm.com/docs/git-notes> Git notes does not change the commitish, but are more weakly tied to commits and does not have the same "change traceability" as commits does. So I recommend to PGP sign notes (which might need to be handled outside git) if it important to ensure the note is unchanged. But a note can be AFAIK, it doesn't push or fetch notes by default, so that might need to be handled separately, using: $ git push <remote> refs/notes/* To fetch remote notes: $ git fetch <remote> refs/notes/*:refs/notes/* We already have a few notes in our repo for similar situations or clarifications. -- kind regards, David Sommerseth OpenVPN Inc
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
